Comment 5 for bug 322206
Revision history for this message
| Stuart Bishop (stub) wrote Re: [Bug 322206] Re: PostgreSQL string quoting type detection spams error logs | #5 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
On Sat, Jan 31, 2009 at 9:50 AM, James Henstridge
<email address hidden> wrote:
> The E'' quote stuff was fixed in psycopg2 2.0.7 (released a bit over 9
> months ago). If you are using an older version than that, then you also
> have broken error handling for commit. Not knowing whether commits
> succeed or fail is a pretty big problem if you care about your data ...
>
> If the E'' quoting was the only important fix in the later versions of
> psycopg2 I might agree with you, but the other fixes are important
> enough that I'd be worried about anyone running on older versions.
>
> If Landscape is still running on an ancient version, you should
> definitely look at upgrading. The IS team already has 2.0.8 installed
> for Launchpad and Online Services, so it shouldn't be a big deal
> installing it for Landscape too.
So the fix for Storm is to require psycopg2 2.0.7+ and remove the
detection code? That suites me fine, and protects Storm and its users
from known data loss bugs.
I'm happy to submit the patch if this is the way forward.
--
Stuart Bishop <email address hidden>
http://