Comment 3 for bug 434407

Revision history for this message
Skipper Seabold (jsseabold) wrote :

Good catch. That was a typo. Should be res[:,-1] I think (not on a machine where I can test).

Part of fixing this "bug" should be adding the checks for shapes. I would like the user to never have to worry about whether the shape is 1d or 2d ie., (N,) vs (N,1). Part of the inconsistency now is from pinv and dot not being able to distinguish between the two (though with good reason in this case). That way, it should be the first test that's written for new models. It's not clear right now how much can be moved up to the parent class wrt your comments on GLSAR.