When the remote execution or encryption features are selected the code
for validation of OS_REGION_NAME fails either due to missing file (not
delegated to inspection target) or due to the encrypted file.
Move the region_name validation code to restore-platform/prepare-env
where validation of the platform backup file is run.
While unit testing also fix:
- Delegate inspection of platform backup file to inspection target
- Do not repeat test for existing platform backup file
- Ensure platform backup file is not encrypted when encryption is not
selected
Test Plan:
PASS: Unit test combinations of: missing file, encrypted file, non-encrypted file, local/remote execution, encryption
enabled, not-enabled
PASS: Standard controller storage 2+1, B&R, encryption enabled,
local playbook execution
PASS-ish: AIO-SX, B&R, local playbook execution, encryption not-enabled,
up to ceph issue which is supposed to be fixed by: https://review.opendev.org/c/starlingx/ansible-playbooks/+/916889
PASS-ish: Standard controller storage 2+1, B&R, encryption enabled,
remote playbook execution, up to bug 2075200: https://bugs.launchpad.net/starlingx/+bug/2075200
PASS-ish: AIO-SX, IPv6, B&R, remote playbook, encryption enabled,
with cherry-picked fixes for ceph issue and bug 2075200
PASS: dc-vault - DC duplex system controller, simplex subcloud. Backup
of system controller and subcloud. Restore of the system controller, dc-vault; local playbook execution.
PASS-ish: Subcloud restore from dc-vault (remote playbook execution);
failed at "Wait up to 900 seconds for ssh port to become
available for subcloud_LabI" due to missing bootstrap ip address (controller0_address .3, as opposed to floating .2)
Closes-bug: 2074094
Change-Id: I587b66799813eb2c9178129e6edf555dab9cf0b8
Signed-off-by: Michel Thebeau <email address hidden>
Reviewed: https:/ /review. opendev. org/c/starlingx /ansible- playbooks/ +/924967 /opendev. org/starlingx/ ansible- playbooks/ commit/ 8734141b5cdc8e5 1f0d4fefb75bffd 8847d7e559
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 8734141b5cdc8e5 1f0d4fefb75bffd 8847d7e559
Author: Michel Thebeau <email address hidden>
Date: Thu Jul 25 11:49:22 2024 -0400
move validation of OS_REGION_NAME
When the remote execution or encryption features are selected the code
for validation of OS_REGION_NAME fails either due to missing file (not
delegated to inspection target) or due to the encrypted file.
Move the region_name validation code to restore- platform/ prepare- env
where validation of the platform backup file is run.
While unit testing also fix:
- Delegate inspection of platform backup file to inspection target
- Do not repeat test for existing platform backup file
- Ensure platform backup file is not encrypted when encryption is not
selected
Test Plan:
non- encrypted file, local/remote execution, encryption /review. opendev. org/c/starlingx /ansible- playbooks/ +/916889 /bugs.launchpad .net/starlingx/ +bug/2075200
controller, dc-vault; local playbook execution.
(controller0 _address .3, as opposed to floating .2)
PASS: Unit test combinations of: missing file, encrypted file,
enabled, not-enabled
PASS: Standard controller storage 2+1, B&R, encryption enabled,
local playbook execution
PASS-ish: AIO-SX, B&R, local playbook execution, encryption not-enabled,
up to ceph issue which is supposed to be fixed by:
https:/
PASS-ish: Standard controller storage 2+1, B&R, encryption enabled,
remote playbook execution, up to bug 2075200:
https:/
PASS-ish: AIO-SX, IPv6, B&R, remote playbook, encryption enabled,
with cherry-picked fixes for ceph issue and bug 2075200
PASS: dc-vault - DC duplex system controller, simplex subcloud. Backup
of system controller and subcloud. Restore of the system
PASS-ish: Subcloud restore from dc-vault (remote playbook execution);
failed at "Wait up to 900 seconds for ssh port to become
available for subcloud_LabI" due to missing bootstrap ip address
Closes-bug: 2074094
Change-Id: I587b66799813eb 2c9178129e6edf5 55dab9cf0b8
Signed-off-by: Michel Thebeau <email address hidden>