Comment 7 for bug 2070487

Reviewed: https://review.opendev.org/c/starlingx/config/+/923682
Committed: https://opendev.org/starlingx/config/commit/b84ed695f86c08b314be55ca38dc78538d0d9ef7
Submitter: "Zuul (22348)"
Branch: master

commit b84ed695f86c08b314be55ca38dc78538d0d9ef7
Author: fperez <email address hidden>
Date: Mon Jul 8 20:26:16 2024 -0300

    Fix wrong hieradata generation

    Some configs containing the force flag could generate incorrect
    hieradata files for unintended hosts. This commit introduces additional
    verification to prevent this issue, mainly by checking key
    configurations that should be present at the moment hieradata is
    generated.
    In addition, this commits introduces some refactoring to better handle
    a configurations with force flag.

    Test plan:
              PASS:
              Install DX and verify that the system is healthy.
              Ensure no presence of alarms. Verify that all hosts are in
              the status: 'unlocked | enabled | available'.
              Check sysinv.log to confirm that this verification is
              preventing the incorrect generation of data.

              PASS:
              Install Dx + compute(s) and verify that the puppet
              config is not being created in controller-0 at an
              inappropriate time.
              Ensure No presence of alarms and verify all hosts are in
              status 'unlocked | enabled | available'.

              PASS:
              Check collected ssl_ca certificates installed for the compute
              node and the active controller. Compare and verify that both
              are equal.

    Partial-Bug: 2070487

    Signed-off-by: fperez <email address hidden>
    Change-Id: Ic49252b5c08e0d7e2a1212a52d8949a05bd55927