AppFwk: Generic apps fail to apply with no clear error
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Low
|
Igor Pires Soares |
Bug Description
Brief Description
The hello-kitty app is a custom app used in testing to validate custom containers, even after adding the necessary 'supported_
Severity
Minor: System/Feature is usable with minor issue
Steps to Reproduce
get hello-kitty-new.tgz file
upload app tgz
apply hello-kitty app
Expected Behavior
app is applied successfully
Actual Behavior
App fails to apply.
Reproducibility
Reproducible
System Configuration
DX and SX
Load info (eg: 2022-03-
[sysadmin@
SW_VERSION="24.03"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID=
SRC_BUILD_
BUILD_BY="jenkins"
BUILD_NUMBER="748"
BUILD_DATE=
Timestamp/Logs
Sysinv snippet:
[3:07 PM] Gabriel Calixto de Paulasysinv 2024-05-17 17:50:02.863 23283 INFO sysinv.
sysinv 2024-05-17 17:50:02.912 23283 INFO sysinv.
sysinv 2024-05-17 17:50:02.919 23283 INFO sysinv.
sysinv 2024-05-17 17:50:02.962 23283 INFO sysinv.
sysinv 2024-05-17 17:50:02.963 23283 INFO sysinv.
sysinv 2024-05-17 17:50:03.177 23283 ERROR sysinv.
sysinv 2024-05-17 17:50:03.178 23283 INFO sysinv.
sysinv.log
Alarms
N/A
Test Activity
Feature Testing, Regression Testing
Workaround
N/A
Changed in starlingx: | |
status: | New → In Progress |
Changed in starlingx: | |
importance: | Undecided → Low |
tags: | added: stx.10.0 stx.apps |
Changed in starlingx: | |
assignee: | nobody → Igor Pires Soares (ipiresso) |
Reviewed: https:/ /review. opendev. org/c/starlingx /config/ +/920552 /opendev. org/starlingx/ config/ commit/ 66e59f016d8ec26 f82722cd3743cd1 1998da0ded
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 66e59f016d8ec26 f82722cd3743cd1 1998da0ded
Author: Igor Soares <email address hidden>
Date: Mon May 27 12:16:29 2024 -0300
Fix support for generic StarlingX apps
This commit fixes the support for StarlingX applications that do not
provide any plugins, also known as generic apps. Two changes were
required to fix that regression:
* Check if the app is generic when retrieving its charts. A previous of_charts" and
"generate_ helm_applicatio n_overrides" methods are called during the
"generate_ helm_applicatio n_overrides" requires application charts to of_charts" should be called
commit [1] introduced a check to verify whether charts are enabled,
which caused false negatives because generic apps do not provide
plugins to tell if they are enabled or disabled. In light of that,
all charts provided by generic apps should be considered as enabled.
* Swap the order that the "_get_list_
application apply process. The call to
be passed as a parameter, so "_get_list_
first.
In addition, an error log message was added to cover the scenario where
no application charts are found. That will provide better information
for developers that eventually makes mistakes when structuring their
apps. Otherwise, the apply process would silently abort with no clear
error.
[1] https:/ /opendev. org/starlingx/ config/ commit/ 967eedadb73b93a 4098975663b3b22 1d83b4d5ce
Test Plan: apply/remove/ delete generic app.
Remove/ Delete dell-storage.
PASS: build-pkgs -a && build-image.
PASS: AIO-SX fresh install.
PASS: Upload/
PASS: Upload dell-storage app.
Enable csm-replication replication chart.
Apply user overrides.
Apply dell-storage.
Confirm that the enabled chart was installed.
Closes-bug: 2067430
Change-Id: Ib6fbd53209e19b 12c5dbedc3584e0 4f8261363f4
Signed-off-by: Igor Soares <email address hidden>