Comment 1 for bug 2067430

Reviewed: https://review.opendev.org/c/starlingx/config/+/920552
Committed: https://opendev.org/starlingx/config/commit/66e59f016d8ec26f82722cd3743cd11998da0ded
Submitter: "Zuul (22348)"
Branch: master

commit 66e59f016d8ec26f82722cd3743cd11998da0ded
Author: Igor Soares <email address hidden>
Date: Mon May 27 12:16:29 2024 -0300

    Fix support for generic StarlingX apps

    This commit fixes the support for StarlingX applications that do not
    provide any plugins, also known as generic apps. Two changes were
    required to fix that regression:

      * Check if the app is generic when retrieving its charts. A previous
        commit [1] introduced a check to verify whether charts are enabled,
        which caused false negatives because generic apps do not provide
        plugins to tell if they are enabled or disabled. In light of that,
        all charts provided by generic apps should be considered as enabled.
      * Swap the order that the "_get_list_of_charts" and
        "generate_helm_application_overrides" methods are called during the
        application apply process. The call to
        "generate_helm_application_overrides" requires application charts to
        be passed as a parameter, so "_get_list_of_charts" should be called
        first.

    In addition, an error log message was added to cover the scenario where
    no application charts are found. That will provide better information
    for developers that eventually makes mistakes when structuring their
    apps. Otherwise, the apply process would silently abort with no clear
    error.

    [1] https://opendev.org/starlingx/config/commit/967eedadb73b93a4098975663b3b221d83b4d5ce

    Test Plan:
    PASS: build-pkgs -a && build-image.
    PASS: AIO-SX fresh install.
    PASS: Upload/apply/remove/delete generic app.
    PASS: Upload dell-storage app.
          Enable csm-replication replication chart.
          Apply user overrides.
          Apply dell-storage.
          Confirm that the enabled chart was installed.
          Remove/Delete dell-storage.

    Closes-bug: 2067430

    Change-Id: Ib6fbd53209e19b12c5dbedc3584e04f8261363f4
    Signed-off-by: Igor Soares <email address hidden>