Comment 1 for bug 2065699

Reviewed: https://review.opendev.org/c/starlingx/config/+/918947
Committed: https://opendev.org/starlingx/config/commit/e692da31a26be84a5b6c2e6d954209c4359c3945
Submitter: "Zuul (22348)"
Branch: master

commit e692da31a26be84a5b6c2e6d954209c4359c3945
Author: Igor Soares <email address hidden>
Date: Thu May 9 16:58:47 2024 -0300

    Fix download of images provided via user overrides

    This commit fixes a bug that was causing container images provided via
    user overrides not to be downloaded when applying StarlingX
    applications. The problem was caused by two issues:

      * The way the chart override filename was assembled in the image
        download method got outdated due to a previous commit [1]. The
        global namespace once present in the filename is not mandatory
        anymore as it represents the namespace of FluxCD resources and not
        necessarily the namespace of all underlying resources. In order to
        fix this the download method now uses a helper function, created on
        the same referenced commit, which aims to standardize how override
        filenames are assembled.
      * The implementation assumed that override files loaded using ruamel
        always have a "data:values" section, which is not the case for
        every supported app. This was causing the overrides parsing
        function to receive an empty dictionary, thus returning no images
        to override. That assumption was removed and the whole file is now
        being parsed given that image tags can be present in different
        subsections of the yaml file.

    [1] https://review.opendev.org/c/starlingx/config/+/887430

    Test plan:
    PASS: build-pkgs -a && build-image
    PASS: AIO-SX fresh install
    PASS: Override vault-manager image using "system helm-override-update".
          Apply vault app.
          Confirm that sysinv attempted to download the image provided via
          user overrides.
    PASS: Apply vault app.
          Confirm that default images were correctly downloaded.
    PASS: Override ceph_config_helper image using
          "system helm-override-update".
          Apply platform-integ-apps.
          Confirm that sysinv attempted to download the image provided via
          user overrides.
    PASS: Apply platform-integ-apps app.
          Confirm that default images were correctly downloaded.

    Closes-bug: 2065699

    Change-Id: I9cc6b8522aaf2624377814b2249e3c00da9ec424
    Signed-off-by: Igor Soares <email address hidden>