Comment 2 for bug 2057934

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/913200
Committed: https://opendev.org/starlingx/distcloud/commit/0e24a87afb2b53ca0fbe1d46687c8852743b203c
Submitter: "Zuul (22348)"
Branch: master

commit 0e24a87afb2b53ca0fbe1d46687c8852743b203c
Author: Gustavo Herzmann <email address hidden>
Date: Thu Mar 14 11:09:48 2024 -0300

    Fix peer-group-association sync_message

    The current message prints the error_msg.keys() directly, which returns
    a dict_keys object. This commit fix the SPA sync_message by casting it
    to a list.

    This commit also fixes a log message where the subcloud name and peer
    name order was inverted.

    Test Plan:
    1. PASS - Try to sync a PGA that has the rehome-failed state in the
              non-primary site, causing the sync to fail. Verify that the
              sync_message prints the subcloud list without including the
              'dict_keys' string;
    2. PASS - Introduce an error during the _delete_subcloud() function
              and then try to delete the peer group association. Verify
              that the sync_message prints the subcloud list without
              including the 'dict_keys' string;
    3. PASS - During SPG migration, verify that the modified log message
              prints the subcloud name and peer site name in the correct
              order.

    Closes-Bug: 2057934

    Change-Id: Idfdc2cc1731a51c6098a06863b2469c3085aa813
    Signed-off-by: Gustavo Herzmann <email address hidden>