Comment 2 for bug 2055463

Reviewed: https://review.opendev.org/c/starlingx/config/+/910661
Committed: https://opendev.org/starlingx/config/commit/b2e75b771fb8c6f779ef96939fac3a620cf36e0f
Submitter: "Zuul (22348)"
Branch: master

commit b2e75b771fb8c6f779ef96939fac3a620cf36e0f
Author: Joshua Reed <email address hidden>
Date: Thu Feb 29 13:23:54 2024 -0700

    Fix sysinv-helm command.

    Running the sysinv-helm command to create fluxcd app
    overrides fails with a stack trace printed to terminal.

    This fix pre-populates the apps_metadata_dict variable with
    an empty dictionary in the event that its empty, which it would
    be the first time when this command is run.

    Test Plan:
    PASS: Verify command 1 below produces {} in the output yaml.
    PASS: Verify command 2 below produces fully populated output
          accross several yaml files.
    PASS: Verify sysinv conductor starts up correctly with these
          changes in place.

    Command 1:
    system application-upload \
      /usr/local/share/applications/helm/metrics-server-1.1-44.tgz
    sudo sysinv-helm create-fluxcd-app-overrides \
      /home/sysadmin metrics-server metrics-server

    Command 2:
    sudo sysinv-helm create-fluxcd-app-overrides \
      /home/sysadmin platform-integ-apps kube-system

    Closes-Bug: 2055463

    Change-Id: I3251776653bcfb1cf11f3dfec388953d476b8465
    Signed-off-by: Joshua Reed <email address hidden>