Comment 9 for bug 2051578

Reviewed: https://review.opendev.org/c/starlingx/metal/+/912278
Committed: https://opendev.org/starlingx/metal/commit/3c94b0e552ce7aeed29603a3476b7a7d07847f84
Submitter: "Zuul (22348)"
Branch: master

commit 3c94b0e552ce7aeed29603a3476b7a7d07847f84
Author: Eric MacDonald <email address hidden>
Date: Fri Mar 8 15:55:33 2024 +0000

    Avoid creating non-volatile node locked file while in simplex mode

    It is possible to lock controller-0 on a DX system before controller-1
    has been configured/enabled. Due to the following recent updates this
    can lead to SM disabling all controller services on that now locked
    controller-0 thereby preventing any subsequent controller-0 unlock
    attempts.

    https://review.opendev.org/c/starlingx/metal/+/907620
    https://review.opendev.org/c/starlingx/ha/+/910227

    This update modifies the mtce node locked flag file management so that
    the non-volatile node locked file (/etc/mtc/tmp/.node_locked) is only
    created on a locked host after controller-1 is installed, provisioned
    and configured.

    This prevents SM from shutting down if the administrator locks
    controller-0 before controller-1 is configured.

    Test Plan:

    PASS: Verify AIO DX Install.
    PASS: Verify Standard System Install.
    PASS: Verify Swact back and forth.
    PASS: Verify lock/unlock of controller-0 prior to controller-1 config
    PASS: Verify the non-volatile node locked flag file is not created
          while the /etc/platform/simplex file exists on the active
          controller.
    PASS: Verify lock and delete of controller-1 puts the system back
          into simplex mode where the non-volatile node locked flag file
          is once again not created if controller-0 is then unlocked.
    PASS: Verify an existing non-volatile node locked flag file is removed
          if present on a node that is locked without new persist option.
    PASS: Verify original reported issue is resolved for DX systems.

    Closes-Bug: 2051578
    Change-Id: I40e9dd77aa3e5b0dc03dca3b1d3d73153d8816be
    Signed-off-by: Eric MacDonald <email address hidden>