Comment 7 for bug 2051578

Reviewed: https://review.opendev.org/c/starlingx/ha/+/910227
Committed: https://opendev.org/starlingx/ha/commit/91fa44188cd6fa24645e958550cf3c9c0ca3e654
Submitter: "Zuul (22348)"
Branch: master

commit 91fa44188cd6fa24645e958550cf3c9c0ca3e654
Author: Eric MacDonald <email address hidden>
Date: Fri Feb 2 16:52:50 2024 +0000

    Add node locked gate to SM enable for DX systems

    Service Management (SM) sometimes selects and activates services on a
    locked controller following a dead office recovery.

    This update adds a node locked check to SM's enable handler to
    block enable if present much like the existing goenabled check
    blocks enable if not present in the same function.

    The enable gate file is /etc/mtc/tmp/.node_locked on the local host.

    Maintenance manages the presence or absence of this file based on
    the node's administrative state.

    This update also cleans up some extra whitespace in the changed file.

    Test Plan:

    PASS: Verify system build.
    PASS: Verify AIO SX install.
    PASS: Verify AIO DX install.
    PASS: Verify Standard DX system install with worker and storage.

    For Both 'AIO DX' and 'Standard DX with worker and storage':

    PASS: Verify SM does not activate on a locked DX controller.
    PASS: ... DOR case
    PASS: ... Uncontrolled Swact case
    PASS: Verify Standard DX behavior over DOR with one locked controller
          while the only unlocked controller does not recover.
    PASS: Verify behavior after above test case once the only unlocked
          controller does recover.
    PASS: Verify lock of the standby controller and its sm logs
    PASS: Verify manually creating the new Nv locked file on the active
          controller will cause SM to go disabled and shut down all
          services on that controller.
          ... If there is another unlocked controller then verify it
              takes over as an uncontrolled swact.
          ... If there is no unlocked standby controller then verify SM
              remains shutdown until the manually created Nv node locked
              file is removed. At which point SM proceeds to activate
              services on that controller again.

    PASS: Verify SM ignores the node locked flag file for AIO SX systems.
    PASS: Verify lock/unlock of AIO SX controller.
    PASS: Verify original reported issue is resolved for AIO DX systems.

    Regression:

    PASS: Verify controlled swact with unlocked enabled standby.
    PASS: Verify uncontrolled swact with unlocked enabled standby.
    PASS: Verify standby controller lock/unlock soak loop (10).
    PASS: Verify swact loop soak (10).
    PASS: Verify no crash or core dumps.
    PASS: Verify SM logging

    Closes-Bug: 2051578
    Change-Id: If8e27ef30d62096fa77c3868f4d460b18e10ade2
    (cherry picked from commit 23d0d8ab2f3225f10594547c5f8a67c409f815a0)