commit 313c3b1d1dc1a3b8b800a417dfe409391cb83ad1
Author: Gabriel de Araújo Cabral <email address hidden>
Date: Sun Dec 3 20:21:14 2023 -0300
Add SnapshotClass Creation for CephFS/RBD via Helm Override
This commit introduces the capability to create a snapshot
class using helm overrides within "cephfs-provisioner"
and "rbd-provisioner" charts.
By default, upon applying platform-integ-apps the
'snapshotClass.create' field is set to 'false' in both charts,
creating the snapshot class(es) after being changed to 'true' via
helm overrides and the app reapplied.
This enhancement depends on the changes from the review below,
where in each installation the CRDs and the snapshot-controller
will be created by default when running bootstrap playbook.
This way, each CSI app will be able to implement this functionality
as support for PVC snapshots will be default during installations.
Test Plan:
PASS: Build a new app package with the code changes
PASS: Successfully execute upload, apply, remove, and delete operations for 'platform-integ-apps' on both AIO-SX and
AIO-DX environments.
PASS: Upon initial application apply and update, check with
'helm get values' that the 'snapshotClass.create' field
is set to 'false' in both the cephFS and RBD charts. Additionally, confirm on K8s that the snapshotClasses are not
created, as expected
PASS: Use 'system helm-override-update' to change the 'snapshotClass.create' field to 'true' in both charts.
Reapply the app and validate on K8s that the snapshotClasses
are indeed created.
PASS: After creating the SnapshotClass, take a VolumeSnapshot
from an existing PVC, proceed with K8s upgrade (K8s 1.25,
1.26, and 1.27) with CRDs and snapshot controller update,
take a VolumeSnapshot from another PVC and verify that
all VolumeSnapshots are correct
PASS: With an old version of the application, create user overrides
for 'classes', then update to the application with the
current changes and verify that the user overrides for 'classes' have been transferred to 'storageClasses'
Reviewed: https:/ /review. opendev. org/c/starlingx /platform- armada- app/+/904361 /opendev. org/starlingx/ platform- armada- app/commit/ 313c3b1d1dc1a3b 8b800a417dfe409 391cb83ad1
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 313c3b1d1dc1a3b 8b800a417dfe409 391cb83ad1
Author: Gabriel de Araújo Cabral <email address hidden>
Date: Sun Dec 3 20:21:14 2023 -0300
Add SnapshotClass Creation for CephFS/RBD via Helm Override
This commit introduces the capability to create a snapshot provisioner"
class using helm overrides within "cephfs-
and "rbd-provisioner" charts.
By default, upon applying platform-integ-apps the ass.create' field is set to 'false' in both charts,
'snapshotCl
creating the snapshot class(es) after being changed to 'true' via
helm overrides and the app reapplied.
This enhancement depends on the changes from the review below,
where in each installation the CRDs and the snapshot-controller
will be created by default when running bootstrap playbook.
This way, each CSI app will be able to implement this functionality
as support for PVC snapshots will be default during installations.
* This is a new review after the revert of: /review. opendev. org/c/starlingx /platform- armada- app/+/902722
https:/
Test Plan:
operations for 'platform- integ-apps' on both AIO-SX and create' field
Additionall y, confirm on K8s that the snapshotClasses are not update' to change the
'snapshotCl ass.create' field to 'true' in both charts.
'classes' have been transferred to 'storageClasses'
PASS: Build a new app package with the code changes
PASS: Successfully execute upload, apply, remove, and delete
AIO-DX environments.
PASS: Upon initial application apply and update, check with
'helm get values' that the 'snapshotClass.
is set to 'false' in both the cephFS and RBD charts.
created, as expected
PASS: Use 'system helm-override-
Reapply the app and validate on K8s that the snapshotClasses
are indeed created.
PASS: After creating the SnapshotClass, take a VolumeSnapshot
from an existing PVC, proceed with K8s upgrade (K8s 1.25,
1.26, and 1.27) with CRDs and snapshot controller update,
take a VolumeSnapshot from another PVC and verify that
all VolumeSnapshots are correct
PASS: With an old version of the application, create user overrides
for 'classes', then update to the application with the
current changes and verify that the user overrides for
Partial-Bug: 2045897
Depends-on: https:/ /review. opendev. org/c/starlingx /ansible- playbooks/ +/904360
Change-Id: I6e2fe2009d4cce 3e351142359c1f3 6465cf03ee3
Signed-off-by: Gabriel de Araújo Cabral <email address hidden>
Signed-off-by: Erickson Silva de Oliveira <email address hidden>