Comment 2 for bug 2045897

Reviewed: https://review.opendev.org/c/starlingx/platform-armada-app/+/902722
Committed: https://opendev.org/starlingx/platform-armada-app/commit/8b1f987add87d217f720f505b9f65f80fc8dbd20
Submitter: "Zuul (22348)"
Branch: master

commit 8b1f987add87d217f720f505b9f65f80fc8dbd20
Author: Gabriel de Araújo Cabral <email address hidden>
Date: Sun Dec 3 20:21:14 2023 -0300

    Add SnapshotClass Creation for CephFS/RBD via Helm Override

    This commit introduces the capability to create a snapshot
    class using helm overrides within "cephfs-provisioner"
    and "rbd-provisioner" charts.

    By default, upon applying platform-integ-apps the
    'snapshotClass.create' field is set to 'false' in both charts,
    creating the snapshot class(es) after being changed to 'true' via
    helm overrides and the app reapplied.

    This enhancement depends on the changes from the review below,
    where in each installation the CRDs and the snapshot-controller
    will be created by default when running bootstrap playbook.
    This way, each CSI app will be able to implement this functionality
    as support for PVC snapshots will be default during installations.

    Depends-on: https://review.opendev.org/c/starlingx/ansible-playbooks/+/902811

    Test Plan:
     PASS: Build a new app package with the code changes
     PASS: Successfully execute upload, apply, remove, and delete
           operations for 'platform-integ-apps' on both AIO-SX and
           AIO-DX environments.
     PASS: Upon initial application apply and update, check with
           'helm get values' that the 'snapshotClass.create' field
           is set to 'false' in both the cephFS and RBD charts.
           Additionally, confirm on K8s that the snapshotClasses are not
           created, as expected
     PASS: Use 'system helm-override-update' to change the
           'snapshotClass.create' field to 'true' in both charts.
           Reapply the app and validate on K8s that the snapshotClasses
           are indeed created.
     PASS: After creating the SnapshotClass, take a VolumeSnapshot
           from an existing PVC, proceed with K8s upgrade (K8s 1.25,
           1.26, and 1.27) with CRDs and snapshot controller update,
           take a VolumeSnapshot from another PVC and verify that
           all VolumeSnapshots are correct

    Partial-Bug: 2045897

    Change-Id: I47b897d179c4260fad9171586fe2fbd69f7145de
    Signed-off-by: Gabriel de Araújo Cabral <email address hidden>