Comment 3 for bug 2044413

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/901776
Committed: https://opendev.org/starlingx/stx-puppet/commit/578b64b6ee77d7769af186a33dfba0f0c6184401
Submitter: "Zuul (22348)"
Branch: master

commit 578b64b6ee77d7769af186a33dfba0f0c6184401
Author: Jim Gauld <email address hidden>
Date: Thu Nov 23 15:12:22 2023 -0500

    Add kube_command helper for logging instrumentation

    This adds define platform::kubernetes::kube_command so that we can
    reuse common mechanism to log puppet exec output even in cases when
    puppet exec hits timeout.

    This is now being called in multiple places specifically for
    kubernetes upgrade commands that run generally long and are
    difficult to debug.

    This identical mechanism was used previously for:
    - 'kubeadm upgrade apply'
    - 'kubectl drain'

    This will add instrumentation for:
    - 'kubeadm upgrade node'

    TEST CASES:
    PASS: Run orchestrated kubernetes upgrade: AIO-SX, AIO-DX, STANDARD.
          Verify we get file output logs in /var/log/puppet/<dir>/
          for kube-upgrade-apply.log and kube-upgrade-node.log with
          verbose output.
    PASS: Issue 'system kube-config-kubelet' and verify we get output
          Verify we get file output logs in /var/log/puppet/<dir>/
          for: kubeadm-upgrade-node-phase-kubelet-config.log .
    PASS: Manually modify code to reduce timeout to 1 second,
          demonstrate that doing 'kubeadm upgrade node' will timeout
          and provide log output.

    Partial-Bug: #2044413

    Change-Id: Id898b4bd7e9ee3a1d833439ee71b9355edd7d865
    Signed-off-by: Jim Gauld <email address hidden>