The SM_FAILOVER_IF_STATE_MASK change from 0xF to 0x3F
mask was clearing the HEARTBEAT ALIVE flag.
SM_FAILOVER_HEARTBEAT_ALIVE = (0x1 << 4), // 16
This change restores previous system behavior. Tester performs a
cable pull on the oam ports. The expected behavior is an alarm
being raised. Instead the standby controller ended up getting rebooted.
oam interface testing was simulated by bringing the ip link down for 1
second.
For example:
sudo ip link set <oam> down; sleep 1 ; sudo ip link set <oam> up
-----------------
Before change
-----------------
- Heartbeat loss on oam interface resulted in standby controller reboot
-----------------
After change:
-----------------
- Heartbeat loss on oam interface resulted in alarm raised
- Logs indicate the health score of controller-1 drops by 1 point
Test plan:
PASS - AIO-SX: iso install
PASS - AIO-DX: iso install drop oam interface on standby verify standby controller-1 is not rebooted by active controller-0 restore oam interface
PASS - AIO-DX: system host-swact . swact back and forth
Reviewed: https:/ /review. opendev. org/c/starlingx /ha/+/896694 /opendev. org/starlingx/ ha/commit/ efe4a7a3706ff63 81e0bdd8fbc9c21 50d44cba20
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit efe4a7a3706ff63 81e0bdd8fbc9c21 50d44cba20
Author: Kyale, Eliud <email address hidden>
Date: Wed Sep 27 13:45:14 2023 -0400
IF_STATE_MASK fix for SM_FAILOVER_ HEARTBEAT_ ALIVE
The SM_FAILOVER_ IF_STATE_ MASK change from 0xF to 0x3F
mask was clearing the HEARTBEAT ALIVE flag. FAILOVER_ HEARTBEAT_ ALIVE = (0x1 << 4), // 16
SM_
This change restores previous system behavior. Tester performs a
cable pull on the oam ports. The expected behavior is an alarm
being raised. Instead the standby controller ended up getting rebooted.
oam interface testing was simulated by bringing the ip link down for 1
second.
For example:
sudo ip link set <oam> down; sleep 1 ; sudo ip link set <oam> up
--- ------- ------- ------- -------
Before change
---
- Heartbeat loss on oam interface resulted in standby controller reboot
--- ------- ------- ------- -------
After change:
---
- Heartbeat loss on oam interface resulted in alarm raised
- Logs indicate the health score of controller-1 drops by 1 point
Test plan:
PASS - AIO-SX: iso install
PASS - AIO-DX: iso install
drop oam interface on standby
verify standby controller-1 is not rebooted
by active controller-0
restore oam interface
PASS - AIO-DX: system host-swact . swact back and forth
Closes-Bug: 2037579
Change-Id: I4f1ffc1169d4df 090f71377e5aa82 47e1cd17fc3
Signed-off-by: Kyale, Eliud <email address hidden>