Comment 5 for bug 2034753

Reviewed: https://review.opendev.org/c/starlingx/metal/+/897328
Committed: https://opendev.org/starlingx/metal/commit/d24e48e490acfaf361a2c7bbc28ef42faef71d20
Submitter: "Zuul (22348)"
Branch: master

commit d24e48e490acfaf361a2c7bbc28ef42faef71d20
Author: Salman Rana <email address hidden>
Date: Wed Oct 4 05:56:50 2023 -0400

    Fix kickstarts patching

    Ostree doesn't manage the /var filesystem. Anything
    installed there during initial filesystem setup becomes
    unpatchable [1]. As a result, the kickstart install dir
    /var/www/pages/feed/rel-${platform_release}/kickstart
    is not updated according to patch changes. /var/www/pages/feed/rel-${platform_release}/kickstart
    is currently only used for PXE boot installs.
    Subcloud remote installations are using the miniboot.cfg
    kickstart from the load-imported ISO
    (we may want to change this in some future commit).

    This commit adds kickstart update support to
    pxeboot-feed.service (pxeboot_feed.sh) so that
    /var/www/pages/feed/rel-${platform_release}/kickstarts
    is refreshed based on the kickstart dir from
    /ostree (i.e., the patched changes).

    [1] https://review.opendev.org/c/starlingx/ha/+/890918

    Test Plan:
    1. PASS: Verify Debian build and DC system install
             (virtual lab - disk and pxe installs)
    2. PASS: Verify pxe install (DC remote install) with
             patched kickstart
    3. PASS: Create a patch with changes to kickstart feed:
              - modify an existing kickstart
              - create a new kickstart file
              - delete an existing file
              - create a new kickstart sub-directory
              - modify centos subdir
             verify patch apply, ensure that changes are
             correctly applied to:
             /var/www/pages/feed/rel-${platform_release}/kickstarts
    4. PASS: Revert the patch from test #3 and ensure changes
             are correctly undone in the feed dir

    Closes-Bug: 2034753

    Change-Id: I74804bff23a74512db6a95fa514c84a1a6ea54a8
    Signed-off-by: Salman Rana <email address hidden>