Comment 4 for bug 2034446

Reviewed: https://review.opendev.org/c/starlingx/config/+/915030
Committed: https://opendev.org/starlingx/config/commit/5d853423efdb4ba020f7a54f0b1295ef150a26f2
Submitter: "Zuul (22348)"
Branch: master

commit 5d853423efdb4ba020f7a54f0b1295ef150a26f2
Author: Rei Oliveira <email address hidden>
Date: Wed Apr 3 19:20:06 2024 -0300

    Wrap 'classes' parameter as a list in config_dict object

    This change fixes a type mismatch bug introduced in [1]. A python list
    is expected but a python str is provided instead.

    [1] https://review.opendev.org/c/starlingx/config/+/893566

    This type mismatch will result in the 'deadlock' prevention logic to
    never be invoked. In [2] below, the 'if classes' branch is never entered:

    [2] https://opendev.org/starlingx/config/src/commit/85a548ffcc77d708de848a4648352f8481543695/sysinv/sysinv/sysinv/sysinv/conductor/manager.py#L13481

    Test plan:

    PASS: Run 'sudo chage -M 999 sysadmin; sudo chage -M 888 sysadmin;
          sudo chage -M 777 sysadmin'. Notice 'out of config alarm' in
          'fm alarm-list'. Verify that it clears up after about 5 min.
    PASS: Verify in i_user db table and /etc/shadow that it correctly
          contains the last password age, 777 in this case.

    Note: In a managed subcloud, the value in /etc/shadow file will
    be changed again in about 20 min to sync with the sysadmin password
    and age in the system controller.

    Closes-Bug: 2034446

    Signed-off-by: Rei Oliveira <email address hidden>
    Change-Id: I24d9807e9eb2d94e026be7b8f3448a6cd42fcdd6