Comment 4 for bug 2023407

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to metal (master)

Reviewed: https://review.opendev.org/c/starlingx/metal/+/885759
Committed: https://opendev.org/starlingx/metal/commit/5f34e2843db7d936d8e8f12f9432ad7626382f6a
Submitter: "Zuul (22348)"
Branch: master

commit 5f34e2843db7d936d8e8f12f9432ad7626382f6a
Author: Kyle MacLeod <email address hidden>
Date: Thu Jun 8 23:25:46 2023 -0400

    Translate extra_boot_params into disk boot kernel options

    The extra_boot_params install value is presented as a single boot
    parameter in the initial miniboot ISO boot. This kickstart change
    translates the install value into proper disk boot kernel options, so
    that the provided extra_boot_params are applied as boot options for the
    main /boot parameters in grub and syslinux.

    Although the extra_boot_params value must be a single string, multiple
    extra boot parameters can be specified by separating individual args
    by a comma. Example: extra_boot_params=arg1=1,arg2=2. This change splits
    the args by comma and ensures that the kernel boot options are separate
    for the main boot.

    Test Plan
    PASS:
    - Verify that extra_boot_params is parsed into separate kernel options
    - Verify that disk kernel options are applied when subcloud is installed
      (i.e., the final install boots with the configured extra options)
    - Verify comma-separated input values are translated into proper
      kernel options:
        - extra_boot_params=arg1=1,arg2=2 -> kernel options: arg1=1 arg2=2
        - extra_boot_params=arg1=1 -> kernel options: arg1=1
        - extra_boot_params=arg1 -> kernel options: arg1

    Partial-Bug: 2023407
    Depends-On: https://review.opendev.org/c/starlingx/distcloud/+/885758

    Change-Id: I8ed10f7ffe8af51ae7b77eaa398b824347a0a998
    Signed-off-by: Kyle MacLeod <email address hidden>