Comment 2 for bug 2019138

Reviewed: https://review.opendev.org/c/starlingx/config/+/882947
Committed: https://opendev.org/starlingx/config/commit/2785f64e54c425f103600e9a91559555cf748a03
Submitter: "Zuul (22348)"
Branch: master

commit 2785f64e54c425f103600e9a91559555cf748a03
Author: Robert Church <email address hidden>
Date: Wed May 10 10:15:08 2023 -0500

    AppFrmwk: Cleanup unique helm releases over update

    When updating an application some helm releases are unique to a specific
    application version. This requires that a when an application
    successfully or unsuccessfully updates, specific helm releases must be
    removed by the framework as it will not be managed by the new (or old)
    version of the application that is being applied during update (or
    recovery).

    Changes include:
     - When helm releases are cleaned up via delete_helm_release() also
       remove the FluxCD helmrelease CRD so that the helm controller will
       not re-deploy the helm release.
     - Refactor calls to delete_helm_v3_release() to delete_helm_release()
       as helm v2 is no longer supported, so differentiation is irrelevant.
     - Refactor retrieve_helm_releases() by removing the wrapper function
       and renaming retrieve_helm_v3_releases().
     - Refactor HelmTillerFailure exception to HelmFailure. Tiller is no
       longer present in the system as helm v3 is tillerless and the Armada
       pod containing the Tiller container is no longer supported.
     - Fix issue that when an application does not specify any images in any
       chart values.yaml an exception is thrown when applying the
       application due to a null dict being written to the application
       images file.

    Test Plan:
    PASS - Build, install, deploy AIO-SX
    PASS - Build custom platform-integ-apps without the ceph audit chart.
           Perform application update and confirm that the unique helm
           release from the previous application version is properly
           cleaned up.

    Closes-Bug: #2019138
    Signed-off-by: Robert Church <email address hidden>
    Change-Id: I3a14f8f6b990351f8415a3fe3ce0b9637672dbcb