Comment 6 for bug 2019007

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to monitoring (master)

Reviewed: https://review.opendev.org/c/starlingx/monitoring/+/883845
Committed: https://opendev.org/starlingx/monitoring/commit/fc336f95b6c772721d48b79a2665f7dd4df5c34e
Submitter: "Zuul (22348)"
Branch: master

commit fc336f95b6c772721d48b79a2665f7dd4df5c34e
Author: Cesar Bombonate <email address hidden>
Date: Mon May 22 13:43:39 2023 +0000

    Add additional logging for Collectd and fix non descriptive output.

    This change adds additional logging for pods not in the kube-system
    or in the kube-addon namespace that are logged every 30 minutes.

    Additionally we have added additional information for pods
     where the UID was not found.

    The logs now include entries for pods outside of
     kube-addon and kube-system namespaces:
    2023-05-12T15:00:42.351 controller-0 collectd[72599]: info The pod:
    cm-cert-manager-55659b97c7-w52bq running in
    namespace:cert-manager has the following
    processes{95662: {'rss': 55248.0, 'name': 'controller'}
    , 95352: {'rss': 4.0, 'name': 'pause'}}

    Non descriptive logs exemplified below:
    2023-05-08T13:10:50.059 controller-0 collectd[72636]: info
     platform memory usage: uid 261d40cea94de12fc54c41279cf269c9 not found
    2023-05-08T13:10:50.059 controller-0 collectd[72636]: info
     platform memory usage: uid e90a2332-5753-48bc-a706-f611b9fa4f2e not found
    2023-05-08T13:10:50.059 controller-0 collectd[72636]: info
     platform memory usage: uid f38297b6-6940-437d-996b-addacb2cb330 not found

    Thus we have changed this to now include the podname and namespace:
    collectd.warning('%s: uid %s for pod %s not found in namespace %s' % (
                        PLUGIN, uid, pod.name, pod.namespace))

    Test Plan:
       - PASS: Build an image, install and bootstrap successfully
       - PASS: Apply monitor pods so addon logs would be installed.
       - PASS: Check that log entries are correctly displayed.

    Closes-Bug: 2019007
    Signed-off-by: Cesar Bombonate <email address hidden>
    Change-Id: If9207b8d23aefe010d0475e36b0644343df911ea