Comment 3 for bug 2015088

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/879359
Committed: https://opendev.org/starlingx/stx-puppet/commit/c365ae5f8a248569e6eb0a4f7af8c5d5cafa0cc4
Submitter: "Zuul (22348)"
Branch: master

commit c365ae5f8a248569e6eb0a4f7af8c5d5cafa0cc4
Author: Luan Nunes Utimura <email address hidden>
Date: Mon Apr 3 11:35:51 2023 -0300

    Disable guest plugin loading in VIM

    Following the work previously done in [1] and [2] to deactivate
    guest-related services in VIM, since they were no longer being utilized
    and causing coredump issues in the platform, this commit changes the
    default value for the `guest_plugin_disable` config variable so
    that Puppet won't reinforce the guest plugin loading in VIM.

    As reported in [3], loading this plugin while having some of its
    services deactivated (or functionalities removed) has proven to be
    a problem when stx-openstack is applied, as both nova-compute service
    and hypervisor are caught in an enable/disable loop indefinitely after
    the first host lock/unlock with the application applied.

    [1] https://review.opendev.org/c/starlingx/nfv/+/869817
    [2] https://review.opendev.org/c/starlingx/nfv/+/870538
    [3] https://bugs.launchpad.net/starlingx/+bug/2015088

    Test Plan (on AIO-SX):
    PASS - Build puppet-nfv package
    PASS - Build and install ISO
    PASS - Upload and apply stx-openstack
    PASS - Verify that the `guest_plugin_disable` configuration variable
           remains `True` after the application is applied:
           $ grep 'guest_plugin_disable' /etc/nfv/vim/config.ini
    PASS - Lock and unlock controller-0
    PASS - Verify that both nova-compute service and hypervisor are no
           longer intermittent after the unlock

    Closes-Bug: 2015088

    Signed-off-by: Luan Nunes Utimura <email address hidden>
    Change-Id: Iaebc8cc37eabe7b2b685622a5772544b4bce21dc