Comment 2 for bug 2011604

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/877428
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/1f0ba3b7156f44fc9494af03e71cd75c29b8126c
Submitter: "Zuul (22348)"
Branch: master

commit 1f0ba3b7156f44fc9494af03e71cd75c29b8126c
Author: Victor Romano <email address hidden>
Date: Tue Mar 14 19:07:05 2023 -0300

    Change subcloud backup transfer to synchronize

    If the user makes a backup of a subcloud or any other operation that
    requires ssh/scp as root by hostname using the System Controller,
    the subcloud host key will be saved on the root known_hosts. If the
    subcloud host key changes, like if the system is reinstalled, and
    another backup is attempted, the operation will fail because of the
    presence of the previous host key on the System Controller root
    known_hosts.
    The backup transfer method was changed from running rsync using command
    to the synchronize module from Ansible posix collection, so the ssh
    handling is taken care by Ansible.

    Test plan:
      PASS:
      - Backup subcloud1 using dcmanager
      - Change subcloud1 host keys
        (by removing old keys and running "ssh-keygen -A")
      - Backup new subcloud and verify that the process ended without errors
      PASS:
      - Backup subcloud1 using dcmanager
      - Delete and reinstall subcloud1
      - Backup new subcloud and verify that the process ended without errors

    Closes-Bug: 2011604

    Signed-off-by: Victor Romano <email address hidden>
    Change-Id: I561b496be978a13fb2bdded0acf6f6534aed42ac