Comment 3 for bug 1999971

Reviewed: https://review.opendev.org/c/starlingx/config/+/868035
Committed: https://opendev.org/starlingx/config/commit/3853336652cb672717f9d40f767cde0a3e274d17
Submitter: "Zuul (22348)"
Branch: master

commit 3853336652cb672717f9d40f767cde0a3e274d17
Author: Dan Voiculeasa <email address hidden>
Date: Sat Dec 17 20:49:29 2022 +0200

    Sync part of the functions that call playbooks

    It is observed that concurrent calls to docker images download section
    may create problems due to race condition(for example 1 task removes
    the tags while the other expects them to be there).
    This becomes obvious when running upgrades with a race between
    upgrade-static-images.yml and upgrade-fluxcd-controllers.yml.

    Sync with a lock the functions that call upgrade playbooks at
    conductor start, and the one handling upgrade-activate.

    This may not be a complete solution, other playbook calls have to be
    examined.

    Tests on AIO-SX:

    DESC: Emulated race condition by adding a sync for
    _k8s_application_audit function, adding some logging and
    restarting sysinv conductor.
    PASS: Observed _k8s_application_audit called first, and the functions
    that handled the upgrade playbook at conductor start being serialized.

    PASS: AIO-SX bootstrap

    Closes-Bug: 1999971
    Signed-off-by: Dan Voiculeasa <email address hidden>
    Change-Id: Id96fa62b652b438fb71fc1132e3858f1bd3dca50