Comment 1 for bug 1999095

Reviewed: https://review.opendev.org/c/starlingx/integ/+/866804
Committed: https://opendev.org/starlingx/integ/commit/15db2d6990a717f50cb7611b1e4ee76f3c626af7
Submitter: "Zuul (22348)"
Branch: master

commit 15db2d6990a717f50cb7611b1e4ee76f3c626af7
Author: Chris Friesen <email address hidden>
Date: Tue Dec 6 14:33:08 2022 -0600

    clean up feature gates on k8s upgrade

    During a K8s feature upgrade from 1.23 to 1.24 we need to remove
    the "RemoveSelfLink=false" feature gate from kube-apiserver.

    We had previously handled updating the kubeadm configmap, which
    was sufficient to handle the running system. However, in order
    to properly handle backup and restore after the K8s upgrade to
    1.24 (and just for general tidiness) we need to also remove the
    feature gate from the saved service parameters and from the
    last_kube_extra_config_bootstrap.yaml file.

    It's possible that there are other kube-apiserver feature gates
    specified by the end user, this adds a bit of complexity to the
    code.

    Test Plan:
    PASS: Test python script and bash script in isolation.
    PASS: End-to-end test with k8s upgrade and backup/restore with
          manual modification of service parameters and yaml file.
          Tested with AIO-DX, AIO-SX unoptimised restore, and
          AIO-SX optimised restore.
    PASS: K8s upgrade using the new code, ensure service parameter
          and last_kube_extra_config_bootstrap.yaml have been
          updated with "RemoveSelfLink=false" feature gate removed.

    Closes-Bug: 1999095
    Signed-off-by: Chris Friesen <email address hidden>
    Change-Id: I82ecd821d4e1745ab0f480f9f9c0178757521038