Comment 1 for bug 1993842

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/862408
Committed: https://opendev.org/starlingx/stx-puppet/commit/7ac49b1684810aaafc8f0fd7934c16593a38b2d3
Submitter: "Zuul (22348)"
Branch: master

commit 7ac49b1684810aaafc8f0fd7934c16593a38b2d3
Author: Jorge Saffe <email address hidden>
Date: Fri Oct 21 15:37:16 2022 -0400

    Fix legacy service-parameter names integration in k8s custom

    The K8s control plane component configuration can be updated
    via service parameters. There are some service parameter
    names used in earlier versions (legacy) that are different
    from the current valid k8s parameter names, so a translation
    must be done for compatibility reasons. For example
    service-parameter name "admission_plugins" must be
    translated to "enable-admission-plugins"

    When the user uses legacy service parameter names to set k8s
    parameters, the updating script discards them wrongly
    during the cleanup step.

    The changes introduced move the translation of parameter
    names (to the accepted k8s format) after the parameters
    are loaded from hieradata.yaml, so the rest of the script
    is abstracted from the legacy service-parameter nomenclature.

    Test Plan:
    * CENTOS and DEBIAN distro:
      - Fresh Install with AIO-SX and DX/STD.
      - Add parameter with old service-parameter nomenclature.
      - Apply changes on kubernetes service.
      - Verify cluster health and configuration.

    Closes-Bug: 1993842
    Closes-Bug: 1993748

    Signed-off-by: Jorge Saffe <email address hidden>
    Change-Id: I0f789b3b8ce1052fa6be213dc63f5945a1efeb3d