StarlingX

  1. Bug #1988343
  2. Comment #0

Comment 0 for bug 1988343

Revision history for this message
M. Vefa Bicakci (vbicakci) wrote :

Brief Description
-----------------
When a developer adds a URL with '&' characters to dl_files section of meta_data.yaml, the Debian-based StarlingX build system fails with the following errors:

  debrepack - ERROR: 2022-06-29 20:04:31 (3.79 MB/s) - '...' saved [...]
  debrepack - ERROR: [ Failed - "wget -t 5 --wait=15 http://a_url_with_& -O ..." ]

This occurs because the build system passes all arguments to the shell without any quoting, and the '&' character is interpreted as "background-this-command-please" by the shell. The solution is to avoid using Python's subprocess.Popen constructor's "shell" parameter.

Severity
--------
Minor: Only problematic when/if a URL with shell-specific special characters needs to be downloaded from during the build.

I already have a patch for this, and I am opening this bug report as a placeholder to refer to. This is why this template is purposefully incomplete.