Comment 2 for bug 1986854

Reviewed: https://review.opendev.org/c/starlingx/integ/+/853531
Committed: https://opendev.org/starlingx/integ/commit/73632416b3fc5ddaa8e2b4babb93ba00fd6c58ca
Submitter: "Zuul (22348)"
Branch: master

commit 73632416b3fc5ddaa8e2b4babb93ba00fd6c58ca
Author: Kaustubh Dhokte <email address hidden>
Date: Wed Aug 17 15:04:36 2022 -0400

    Preserve kube-apiserver manifest params during upgrade-activate

    This change https://opendev.org/starlingx/integ/commit/a6a5349d025487672fe818aae36a2020a9f9f08c
    (k8s-1.22.5: remove feature-gates)
    adds a script that is run during upgrade activate. The script modifies
    kubeadm cluster config and eventually updates kube-apiserver manifest
    to remove deprecated features-gates in k8s 1.22.

    As 'kubeadm init phase' is rerun in the script, it updates the
    kube-apiserver manifest to be in sync with the kubeadm cluster config.
    In that process, it nullifies the effect of these two commits,
    https://opendev.org/starlingx/stx-puppet/commit/04a1c1b0809f66488bd54e3f31d323430e7d9913
    (Rework advertise address in apiserver-change-param)
    and https://opendev.org/starlingx/stx-puppet/commit/52ace69c837acc7e3aff8a2d584968297afd70fe
    (Amend kube-apiserver 1.23 configuration to use PSP)

    This change adds a function to the script that preserves the effect
    of above listed commits.

    Test Plan:
    On CentOS AIO-SX
    PASS: Upgrade Successful. Check if advertise address in
          kube-apiserver manifest before and after running
          upgrade-activate is same.
          Ensure that the seccomp profile configuration is
          removed after upgrade-activate.
          Kube-apiserver is running and cluster is accessible after
          the upgrade.
    PASS: No Shellcheck errors

    Closes-Bug: 1986854

    Signed-off-by: Kaustubh Dhokte <email address hidden>
    Change-Id: Ib97e14bc5b4ed208e65e16888e1380a3bd9fdb8f