stx/integ uses soon-to-be deprecated pip install --use-deprecated legacy-resolver
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Medium
|
Joshua Kraitberg |
Bug Description
Brief Description
-----------------
The pip team is planning to depreciate the '--use-deprecated legacy-resolver'
install option. While a firm date has yet to be set, We need to be ready for
the change.
Our usage seems to be confined to 'tox.ini' files. When the upstream pip change
change is delivered, we can expect.
- Build failures due to failed unit tests
- Zuul to vote -q on code reviews in some repos
At this time, the offending files are ....
cgcs-root/
cgcs-root/
cgcs-root/
cgcs-root/
cgcs-root/
cgcs-root/
cgcs-root/
cgcs-root/
Severity
--------
Major:
Steps to Reproduce
------------------
Scan source code with ....
grep -r 'use-deprecated' $MY_REPO
Expected Behavior
------------------
Not found
Actual Behavior
----------------
Found 8 files using the offending option
Reproducibility
---------------
100%
System Configuration
-------
N/A
Branch/Pull Time/Commit
-------
March 9, 2022
Last Pass
---------
N/A
Timestamp/Logs
--------------
N/A
Test Activity
-------------
Build
Workaround
----------
N/A
summary: |
- use of soon to be dereciaitad pip install --use-deprecated legacy- - resolver + stx/integ: use of soon to be dereciaitad pip install --use-deprecated + legacy-resolver |
summary: |
- stx/integ: use of soon to be dereciaitad pip install --use-deprecated + stx/integ uses soon-to-be deprecated pip install --use-deprecated legacy-resolver |
tags: | added: stx.7.0 stx.integ stx.zuul |
Changed in starlingx: | |
assignee: | nobody → Ramaswamy Subramanian (rsubrama) |
Changed in starlingx: | |
assignee: | Ramaswamy Subramanian (rsubrama) → Joshua Kraitberg (jkraitbe-wr) |
For stx/integ
Needs 3 changes /github. com/starlingx/ integ/blob/ master/ tox.ini# L8
1) remove the legacy resolver from this line
https:/
2) clamp pylint to the python3 version we are using elsewhere here:
ie: pylint<2.4.0
https:/ /github. com/starlingx/ integ/blob/ master/ tox.ini# L96
3) Fix the absolute import error in storage topology (which should probably be tested on centos and debian)
ie: add the following import
from __future__ import absolute_import
https:/ /github. com/starlingx/ integ/blob/ master/ tools/storage- topology/ storage- topology/ storage_ topology/ exec/storage_ topology. py#L22