stx/integ uses soon-to-be deprecated pip install --use-deprecated legacy-resolver

[Scott Little]

Brief Description
-----------------
The pip team is planning to depreciate the '--use-deprecated legacy-resolver'
install option. While a firm date has yet to be set, We need to be ready for
the change.

Our usage seems to be confined to 'tox.ini' files. When the upstream pip change
change is delivered, we can expect.
- Build failures due to failed unit tests
- Zuul to vote -q on code reviews in some repos

At this time, the offending files are ....
cgcs-root/stx/integ/tox.ini
cgcs-root/stx/audit-armada-app/python-k8sapp-auditd/k8sapp_auditd/tox.ini
cgcs-root/stx/openstack-armada-app/python-k8sapp-openstack/k8sapp_openstack/tox.ini
cgcs-root/stx/platform-armada-app/python-k8sapp-platform/k8sapp_platform/tox.ini
cgcs-root/stx/portieris-armada-app/python-k8sapp-portieris/k8sapp_portieris/tox.ini
cgcs-root/stx/ptp-notification-armada-app/python-k8sapp-ptp-notification/k8sapp_ptp_notification/tox.ini
cgcs-root/stx/snmp-armada-app/python-k8sapp-snmp/k8sapp_snmp/tox.ini
cgcs-root/stx/vault-armada-app/python-k8sapp-vault/k8sapp_vault/tox.ini

Severity
--------
Major:

Steps to Reproduce
------------------
Scan source code with ....
grep -r 'use-deprecated' $MY_REPO

Expected Behavior
------------------
Not found

Actual Behavior
----------------
Found 8 files using the offending option

Reproducibility
---------------
100%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
March 9, 2022

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Build

Workaround
----------
N/A

[Al Bailey (albailey1974)]

For stx/integ

Needs 3 changes
1) remove the legacy resolver from this line
https://github.com/starlingx/integ/blob/master/tox.ini#L8

2) clamp pylint to the python3 version we are using elsewhere here:
ie: pylint<2.4.0

https://github.com/starlingx/integ/blob/master/tox.ini#L96

3) Fix the absolute import error in storage topology (which should probably be tested on centos and debian)
ie: add the following import

from __future__ import absolute_import

https://github.com/starlingx/integ/blob/master/tools/storage-topology/storage-topology/storage_topology/exec/storage_topology.py#L22

[Ghada Khalil (gkhalil)]

This LP will be used to track the stx/integ issues. Other LPs will be created to track the issue in the other repos

[Ghada Khalil (gkhalil)]

The following LPs have been opened for the other repos:
- stx/audit-armada-app: https://bugs.launchpad.net/starlingx/+bug/1966069
- stx/openstack-armada-app: https://bugs.launchpad.net/starlingx/+bug/1966070
- stx/platform-armada-app: https://bugs.launchpad.net/starlingx/+bug/1966071
- stx/portieris-armada-app: https://bugs.launchpad.net/starlingx/+bug/1966072
- stx/ptp-notification-armada-app: https://bugs.launchpad.net/starlingx/+bug/1966073
- stx/snmp-armada-app: https://bugs.launchpad.net/starlingx/+bug/1966075
- stx/vault-armada-app: https://bugs.launchpad.net/starlingx/+bug/1966076

[Ghada Khalil (gkhalil)]

Screening: stx.8.0 / there is no hard deadline for this. Doesn't appear that any other open-infra projects are actively addressing these issues either. Park until after stx.7.0 and target for stx.8.0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/integ/+/853674

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/integ/+/853992

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Joshua Kraitberg <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/integ/+/853674
Reason: Replace by https://review.opendev.org/c/starlingx/integ/+/853992

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/integ/+/853992
Committed: https://opendev.org/starlingx/integ/commit/bcf17e661e6539e5031aeab31723fbd94dd25dd8
Submitter: "Zuul (22348)"
Branch: master

commit bcf17e661e6539e5031aeab31723fbd94dd25dd8
Author: Joshua Kraitberg <email address hidden>
Date: Mon Aug 22 09:50:44 2022 -0400

    Remove Legacy-resolver and changed constraints

    Legacy-resolver will have its support dropped in the future.

    Also, legacy-resolver was masking a dependency conflict that
    required the constraints files be updated. To use the
    updated constraints file, the stx-integ-pylint job had to be
    updated. This update matches what is done in other repos,
    eg. https://github.com/starlingx/update/blob/master/.zuul.yaml#L108.

    Test Plan:
    Execute: tox

    Closes-Bug: 1964372

    Signed-off-by: Joshua Kraitberg <email address hidden>
    Change-Id: I6b71f0cd3d9315f957d6a6a15bf0a22e2a692185