stx/portieris-armada-app uses soon-to-be deprecated pip install --use-deprecated legacy-resolver

[Ghada Khalil]

Brief Description
-----------------
Opened on behalf of <email address hidden>

The pip team is planning to depreciate the '--use-deprecated legacy-resolver'
install option. While a firm date has yet to be set, We need to be ready for
the change.

Our usage seems to be confined to 'tox.ini' files. When the upstream pip change
change is delivered, we can expect.
- Build failures due to failed unit tests
- Zuul to vote -q on code reviews in some repos

This LP tracks addressing the issue with the following files:
cgcs-root/stx/portieris-armada-app/python-k8sapp-portieris/k8sapp_portieris/tox.ini

Severity
--------
Major:

Steps to Reproduce
------------------
Scan source code with ....
grep -r 'use-deprecated' $MY_REPO

Expected Behavior
------------------
Not found

Actual Behavior
----------------
Found 8 files using the offending option

Reproducibility
---------------
100%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
March 9, 2022

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Build

Workaround
----------
N/A

[Ghada Khalil (gkhalil)]

Screening: stx.8.0 / there is no hard deadline for this. Doesn't appear that any other open-infra projects are actively addressing these issues either. Park until after stx.7.0 and target for stx.8.0

[Michel Thebeau [WIND] (mthebeau)]

Under review: https://review.opendev.org/c/starlingx/portieris-armada-app/+/848633

(odd that zuul did not update this bug)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/portieris-armada-app/+/848633
Committed: https://opendev.org/starlingx/portieris-armada-app/commit/e7374ffcebcc0d13aae3fe81349d67871307ef0b
Submitter: "Zuul (22348)"
Branch: master

commit e7374ffcebcc0d13aae3fe81349d67871307ef0b
Author: Karla Felix <email address hidden>
Date: Mon Jul 4 08:45:27 2022 -0400

    Remove --use-deprecated legacy-resolver flag

    The pip team is planning to depreciate the
    '--use-deprecated legacy-resolver'install option.
    While a firm date has yet to be set, We need to be
    ready for the change.

    Test Plan*:

    PASS: Verified that tox runs without issues
    PASS: Generate portieris package.
    PASS: Upload and apply portieris package and check if pod
          is running.

    Note(*): Tested on kubernetes 1.21.8

    Closes-bug: 1966072
    Signed-off-by: Karla Felix <email address hidden>
    Change-Id: Ifc48062f95f3bc44de4a1e1703f9e04b8118d430

[Ghada Khalil (gkhalil)]

Actually this will be included in stx.7.0 since the release branch was not created yet