Comment 0 for bug 1957188

Revision history for this message
M. Vefa Bicakci (vbicakci) wrote :

Brief Description
-----------------

Since commit https://review.opendev.org/plugins/gitiles/starlingx/kernel/+/7b55e47e1d9fe9524b6b6b56cb6cb6efa11938ec the kernel's kthread_cpus= argument parser utilizes a lot of stack space, which may or may not be harmful. This was discovered when building the kernel with the following options:

      CONFIG_MAXSMP=y
      CONFIG_NR_CPUS=8192
      CONFIG_CPUMASK_OFFSTACK=y
      CONFIG_FRAME_WARN=1024

which results in the following compilation-time warning:

        CC kernel/cpu.o
      kernel/cpu.c: In function 'kthread_setup':
      kernel/cpu.c:2475:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=]

Severity
--------
Minor: I am assuming that the warning is not critical, as we have not observed misbehaviour with the kthread_cpus argument, but I would like to fix the issue regardless.

Steps to Reproduce
------------------
Please see above for the build configuration that reproduces the warning.

Expected Behavior
------------------
No kernel build warnings

Actual Behavior
----------------
Kernel build warning about kthread_setup function's frame size exceeding 1KiB.

Reproducibility
---------------
100%

System Configuration
--------------------
Not applicable.

Branch/Pull Time/Commit
-----------------------
The issue is reproduced since the merge of the commit at https://review.opendev.org/plugins/gitiles/starlingx/kernel/+/7b55e47e1d9fe9524b6b6b56cb6cb6efa11938ec

Last Pass
---------
Not applicable.

Timestamp/Logs
--------------
Please see the issue description.

Test Activity
-------------
Exploratory developer testing

Workaround
----------
None.