Comment 4 for bug 1951641

Reviewed: https://review.opendev.org/c/starlingx/utilities/+/818698
Committed: https://opendev.org/starlingx/utilities/commit/467b03c1cad4a6bc9a158733a4e9dcbf63877c3e
Submitter: "Zuul (22348)"
Branch: master

commit 467b03c1cad4a6bc9a158733a4e9dcbf63877c3e
Author: Eric MacDonald <email address hidden>
Date: Fri Nov 19 16:35:57 2021 -0500

    Bypass check_host_reachable check for local host

    Call to check_host_reachable on local host can prevent
    collection of the local host in the presence if certain
    networking config failures that error out on ssh to self.

    There is no need to check_host_reachable for the local host.
    To make collect for local host more fault tolerant this
    update modifies the check_host_reachable function to
    return pass when executed on the local host.
    It's just not needed in that case.

    This update also adds three additional ssh connection
    failure strings to better handle expect timeouts seen
    for some unreachable host test cases scenarios.

    This update also adds the check_host_reachable test
    prior to subcloud clean operation after finding undesirable
    handling in the unreachaable case during update testing.

    Test Plan:

    PASS: Verify check_host_reachable bypasses check for the local host.
    PASS: Verify check_host_reachable for remote hosts and subclouds.

    Regression:

    PASS: Verify collect all hosts
    PASS: Verify collect all subclouds
    PASS: Verify collect local host
    PASS: Verify collect single and subcloud group
    PASS: Verify collect single and host group
    PASS: Verify collect clean single, group and all
          hosts and subclouds with some unreachable

    Change-Id: I8dc6b0a5f021f38a623fcdd6235b545d2671b7ed
    Closes-Bug: 1951641
    Signed-off-by: Eric MacDonald <email address hidden>