Comment 3 for bug 1951431

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/818468
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/eb4f81b2c55853d8c3cfc52132889997178cd783
Submitter: "Zuul (22348)"
Branch: master

commit eb4f81b2c55853d8c3cfc52132889997178cd783
Author: Samuel Presa Toledo <email address hidden>
Date: Thu Nov 18 15:59:11 2021 -0500

    Add check/re-generate default-registry-key on B&R

    This checking prevents errors during the upgrade process mainly for
    All-in-one Simplex (AIO-SX), which relies on the correct execution of
    the Backup and Restore (B&R) process. From this, if there is no
    kube-system default-registry-key, the backup playbook will stop its
    execution and the user will be notified about that absence.

    Moreover, if a platform backup with no default-registry-key for
    kube-system tries to be restored, this modification ensures that
    a default-registry-key for kube-system be created in order to
    restore a host properly.

    Test Plan:
    PASS: Run initial bootstrap successfully
    PASS: B&R runs successfully when host contains the
      default-registry-key for kube-system
    PASS: Platform backup playbook stops its execution when host
      does not contain the default-registry-key for kube-system
    PASS: Restore runs successfully when platform backup
      does not contain the default-registry-key for kube-system
    PASS: Run AIO-SX upgrade successfully

    NOTE:
    The upgrade process was only able to run succesfully after manually
    removing the change from https://review.opendev.org/c/starlingx/stx-
    puppet/+/820418 before the upgrade-activate.

    Closes-bug: 1951431
    Signed-off-by: Samuel Presa Toledo <email address hidden>
    Change-Id: Iaeb1e481503f5d1c3a53332f140d35f373b7d6e1