Comment 7 for bug 1948140

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/823714
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/4e0b27302fe7b6561982ca7d974eaa1eb5f5c986
Submitter: "Zuul (22348)"
Branch: master

commit 4e0b27302fe7b6561982ca7d974eaa1eb5f5c986
Author: Rafael Camargos <email address hidden>
Date: Thu Jan 6 12:56:12 2022 -0300

    Apply apiserver parameters on restore and upgrade

    The bug being fixed here is manifested by backing-up and restoring a
    system with kube-apiserver parameters applied, e.g.: oidc-auth params.
    The parameters are restored and can be displayed by running
    `service-parameter-list` but aren't getting reapplied back.

    The fix consists in running, during the 'restore-more-data' step of the
    restore:

    - Host and system config data update in order to generate the hieradata
      manifest files
    - The `puppet-manifest-apply.sh` script , which is executed both during
      platform upgrade (AIO-SX only) and restore.

    When applying the manifest the kube-apiserver service parameters are
    updated, similarly to running `service-parameter-apply`.

    Test Plan: Apply oidc-auth kube-apiserver parameters and verify these
    are properly restored after B&R and upgrade

    PASS: Verify kube-apiserver service parameters are restored after a
    AIO-SX System Backup and Restore
    PASS: Verify kube-apiserver service parameters are restored after a
    AIO-SX System Upgrade
    PASS: Verify kube-apiserver service parameters are restored after a
    Standard System Backup and Restore

    Regression: Verify system install

    PASS: Verify AIO-SX System install
    PASS: Verify Standard System install

    Closes-Bug: 1948140
    Signed-off-by: Rafael Camargos <email address hidden>
    Change-Id: I4333024fa711cc7bf515bd600c92b647c232ee30