Comment 1 for bug 1933863

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/798389
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/c0bc0d61a48747adc1df3a7667c206550f0b31c9
Submitter: "Zuul (22348)"
Branch: master

commit c0bc0d61a48747adc1df3a7667c206550f0b31c9
Author: John Kung <email address hidden>
Date: Mon Jun 28 17:06:47 2021 -0500

    Fix ansible download_images handle invalid registry

    Exit download_images on exception or when number of failed downloads
    threshold is exceeded. The case for invalid registries or other error,
    such as invalid DNS, is measured about 20 minutes vs 4 hours in the bug
    reported initial error case.

    The playbook will retry and pull the remaining required images; as
    docker will not pull images for the already downloaded images.

    Tests Performed:
    o initial installation and sanity which performs download_images
    o modify registries to point to invalid.docker.registry and
      measure timeouts
    o perform ansible-playbook replay with invalid registries
      Either APIError with Forbidden or 'no auth host' may occur
     (replay with invalid registry or invalid DNS)
    o perform ansible-playbook replay with good registries

    Closes-Bug: 1933863
    Signed-off-by: John Kung <email address hidden>
    Change-Id: Id2dec495ae6f956af7c66f0bcf88931991ece0c4