Comment 2 for bug 1928095

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to metal (master)

Reviewed: https://review.opendev.org/c/starlingx/metal/+/790792
Committed: https://opendev.org/starlingx/metal/commit/ba6c61584d62f4584dab6c8187f5973211e7e720
Submitter: "Zuul (22348)"
Branch: master

commit ba6c61584d62f4584dab6c8187f5973211e7e720
Author: Eric MacDonald <email address hidden>
Date: Tue May 11 12:15:42 2021 -0400

    Refactor background in-service start host services handling

    The maintenance add_handler fsm loads inventory and recovers
    host state over a process restart. If the active controller's
    uptime is less than 15 minutes the restart event is treated as
    a Dead Office Recovery (DOR) and is more forgiving to host
    recovery by scheduling the 'start host services' as a
    background operation so as to not hold up the add operation.

    The current implementation of the background handling of
    'start host services' is not handling the AIO subfunction
    case properly in DOR mode as well as being difficult to
    follow and therfore fix and maintain. This miss handling
    leads to maintenance incorrectly failing the node with a
    subfunction configuration error over the DOR case.

    This update refactors the background handling of 'start host
    services' to fix the issue and improve its clearity and
    maintainability.

    Test Cases:

    PASS: Verify AIO DX DOR handling
    PASS: Verify AIO DX active controller reboot handling
          - standby with uptime ; < 15 min and > 15 min
    PASS: Verify AIO DX standby controller reboot handling
    PASS: Verify subfunction configuration error handling

    Regression:

    PASS: Verify start host services wait/retry handling.
    PASS: Verify start host services failure handling.
    PASS: Verify DOR of Standard system
    PASS: Verify DOR of AIO Plus system
    PASS: Verify AIO System Install
    PASS: Verify Standard System Install
    PASS: Verify AIO plus system install

    Change-Id: Ia4683672e3a2852b5b4837167b2dcd2a1e4e6d57
    Closes-Bug: 1928095
    Signed-off-by: Eric MacDonald <email address hidden>