This change replaces the daemonset rollout restart command with a more
spcific pod delete command that only runs if there is an
sriov-device-plugin pod present on the node. Using the pod delete
command ensures that an existing device-plugin pod is terminated before
the worker manifest completes. The rollout restart command did not
ensure that the pod was terminated before the manifest completed and
could allow user pods to be assigned incorrect VFs if they started up
before the device-plugin pod terminated.
This addresses an issue where pods restarted by k8s-pod-recovery could
be assigned to incorrect VFs if they were started while the
sriov-device-plugin was shutting down. Waiting for the device-plugin
to completely terminate before proceeding with pod-recovery ensures that
the device-plugin will have an accurate view of all device bindings and
can allocate VFs correctly.
Reviewed: https:/ /review. opendev. org/759481 /git.openstack. org/cgit/ starlingx/ stx-puppet/ commit/ ?id=03324f173c3 66fe89fbe9b372e e8a148f33b45b6
Committed: https:/
Submitter: Zuul
Branch: master
commit 03324f173c366fe 89fbe9b372ee8a1 48f33b45b6
Author: Cole Walker <email address hidden>
Date: Fri Oct 23 12:24:34 2020 -0400
Ensure sriovdp is deleted after dev bindings
This change replaces the daemonset rollout restart command with a more device- plugin pod present on the node. Using the pod delete
spcific pod delete command that only runs if there is an
sriov-
command ensures that an existing device-plugin pod is terminated before
the worker manifest completes. The rollout restart command did not
ensure that the pod was terminated before the manifest completed and
could allow user pods to be assigned incorrect VFs if they started up
before the device-plugin pod terminated.
This addresses an issue where pods restarted by k8s-pod-recovery could device- plugin was shutting down. Waiting for the device-plugin
be assigned to incorrect VFs if they were started while the
sriov-
to completely terminate before proceeding with pod-recovery ensures that
the device-plugin will have an accurate view of all device bindings and
can allocate VFs correctly.
Closes-Bug: 1900736
Change-Id: I30fd602208d14a c887d5417fd87f2 7f23050f670
Co-Authored-By: Steven Webster <email address hidden>
Signed-off-by: Cole Walker <email address hidden>