Comment 5 for bug 1900153

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/821622
Committed: https://opendev.org/starlingx/stx-puppet/commit/4cb973737ea18656107eefd42ede7bdfbf549fce
Submitter: "Zuul (22348)"
Branch: master

commit 4cb973737ea18656107eefd42ede7bdfbf549fce
Author: Rafael Camargos <email address hidden>
Date: Mon Dec 13 16:50:58 2021 -0300

    Add advertise address to apiserver-change-params

    This work is fixing two issues:

    1. Executing the apiserver-change-params script will cause the
       kube-apiserver advertise-address parameter to be reset, resulting in
       a disruption in the communication with kubernetes. The cause of this
       bug is that kubeadm config view doesn't dump the advertise-address,
       which is a property of InitConfiguration, so using it only causes
       kubeadm init phase control-plane apiserver to set a default
       advertise-address.
    2. The command kubeadm config view became deprecated in k8s v1.19 and
       was removed in k8s v1.22 as reported on
       https://github.com/kubernetes/kubeadm/issues/2203.

    Test Plan: Verify advertise-address is not reset during apiserver change
    params

    PASS: Verify that modifying and applying kube-apiserver oidc parameters
    doesn't reset advertise-address in
    /etc/kubernetes/manifests/kube-apiserver.yaml
    PASS: Verify that upgrade command `system upgrade-activate` doesn't
    reset advertise-address in /etc/kubernetes/manifests/kube-apiserver.yaml
    PASS: Verify upgrade completes succesfully

    Regression: Verify other kube-apiserver resources are not affected

    PASS: Verify /etc/kubernetes/manifests/kube-apiserver.yaml changes in
    apiserver-change-params are consistent
    PASS: Verify ConfigMap ClusterConfiguration changes in
    apiserver-change-params are consistent
    PASS: Verify ConfigMap kubeadm-config changes in apiserver-change-params
    are consistent

    Notes: Above tests were executed in systems with both kubernetes v1.18.1
    and v1.21.3

    Closes-Bug: 1900153
    Signed-off-by: Rafael Camargos <email address hidden>
    Change-Id: Ic81a8e20990aa88aad240a7c6d9a79dee38aa370