| 2020-08-15 02:38:36 |
Ghada Khalil |
description |
Brief Description
-----------------
Patches that are marked as UNREMOVABLE in the patch xml can still be removed.
It appears there’s a bug in the formal patch code for this tag:
https://opendev.org/starlingx/update/src/branch/master/cgcs-patch/cgcs-patch/cgcs_make_patch/make_patch_functions.py#L1363-L1364
if 'UNREMOVABLE' in self.metadata:
pf.meta.removable = self.metadata['UNREMOVABLE']
This should be pf.meta.unremovable.
Severity
--------
Minor - option is not widely used
Steps to Reproduce
------------------
Write down the steps to reproduce the issue
Expected Behavior
------------------
Write down what was expected after taking the steps written above
Actual Behavior
----------------
State what is the actual behavior
Reproducibility
---------------
<Reproducible/Intermittent/Seen once>
State if the issue is 100% reproducible, intermittent or seen once. If it is intermittent, state the frequency of occurrence
System Configuration
--------------------
<One node system, Two node system, Multi-node system, Dedicated storage, https, IPv4, IPv6 etc.>
Branch/Pull Time/Commit
-----------------------
Branch and the time when code was pulled or git commit or cengn load info
Last Pass
---------
Did this test scenario pass previously? If so, please indicate the load/pull time info of the last pass.
Use this section to also indicate if this is a new test scenario.
Timestamp/Logs
--------------
Attach the logs for debugging (use attachments in Launchpad or for large collect files use: https://files.starlingx.kube.cengn.ca/)
Provide a snippet of logs here and the timestamp when issue was seen.
Please indicate the unique identifier in the logs to highlight the problem
Test Activity
-------------
[Sanity, Feature Testing, Regression Testing, Developer Testing, Evaluation, Other - Please specify]
Workaround
----------
Describe workaround if available |
Brief Description
-----------------
Patches that are marked as UNREMOVABLE in the patch xml can still be removed.
It appears there’s a bug in the formal patch code for this tag:
https://opendev.org/starlingx/update/src/branch/master/cgcs-patch/cgcs-patch/cgcs_make_patch/make_patch_functions.py#L1363-L1364
if 'UNREMOVABLE' in self.metadata:
pf.meta.removable = self.metadata['UNREMOVABLE']
This should be pf.meta.unremovable.
Severity
--------
Minor - option is not widely used
Steps to Reproduce
------------------
- Build a patch with unremovable in the xml
<UNREMOVABLE>Y</UNREMOVABLE>
- On a system, test that the patch cannot be removed
Expected Behavior
------------------
The patch cannot be removed
Actual Behavior
----------------
The patch can be removed
Reproducibility
---------------
Reproducible
System Configuration
--------------------
any
Branch/Pull Time/Commit
-----------------------
all branches; appears to be a day 1 issue
Last Pass
---------
Never
Timestamp/Logs
--------------
N/A
Test Activity
-------------
Patch Build
Workaround
----------
N/A |
|
