Bug in make_patch_functions.py

[Ghada Khalil]

Brief Description
-----------------
Patches that are marked as UNREMOVABLE in the patch xml can still be removed.
It appears there’s a bug in the formal patch code for this tag:

https://opendev.org/starlingx/update/src/branch/master/cgcs-patch/cgcs-patch/cgcs_make_patch/make_patch_functions.py#L1363-L1364

        if 'UNREMOVABLE' in self.metadata:

            pf.meta.removable = self.metadata['UNREMOVABLE']

This should be pf.meta.unremovable.

Severity
--------
Minor - option is not widely used

Steps to Reproduce
------------------
- Build a patch with unremovable in the xml
  <UNREMOVABLE>Y</UNREMOVABLE>
- On a system, test that the patch cannot be removed

Expected Behavior
------------------
The patch cannot be removed

Actual Behavior
----------------
The patch can be removed

Reproducibility
---------------
Reproducible

System Configuration
--------------------
any

Branch/Pull Time/Commit
-----------------------
all branches; appears to be a day 1 issue

Last Pass
---------
Never

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Patch Build

Workaround
----------
N/A

[Ghada Khalil (gkhalil)]

stx.5.0 / low to med priority - would be nice to fix, but not gating

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/746537

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/746537
Committed: https://git.openstack.org/cgit/starlingx/update/commit/?id=f541c94975e8b9b9bbf792fcea2236e15d4c76aa
Submitter: Zuul
Branch: master

commit f541c94975e8b9b9bbf792fcea2236e15d4c76aa
Author: Don Penney <email address hidden>
Date: Fri Aug 14 22:15:50 2020 -0400

    Fix UNREMOVABLE parsing in make_patch_functions.py

    The parsing of the UNREMOVABLE tag in the patch XML is setting the
    wrong metadata flag. It's setting "removable" instead of
    "unremovable", meaning the UNREMOVABLE tag has no effect.

    Change-Id: I6f497a8a76e1c46b33edf896e71ed1266004d964
    Closes-Bug: 1891729
    Signed-off-by: Don Penney <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/update/+/792216

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/update/+/792216

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/update/+/793629

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/update/+/793629
Committed: https://opendev.org/starlingx/update/commit/e7f342378bcfe05e81c53f6d15e44a61e89f6caf
Submitter: "Zuul (22348)"
Branch: f/centos8

commit 49e39fa949850a7d6fc6083539a4cd3390e6172b
Author: Charles Short <email address hidden>
Date: Fri May 28 08:55:08 2021 -0400

    Specify the nodeset zuul jobs

    The py2.7 jobs need to specify xenial
    The py3.6 jobs need to specify bionic
    The focal zuul nodes only have python 3.8 installed in them

    Zuul targets that invoke a generic python3 interpreter such
    as pep8 is not specified.

    Also ignore H216 since we still use py2.7.

    The copyright date was updated in order to trigger
    the zuul jobs, as a no-delta type of change.

    Partial-Bug: 1928978

    Signed-off-by: Charles Short <email address hidden>
    Change-Id: I81fd790dfc8a665a4e4e0ff59a013af7921b6e06
    Signed-off-by: Charles Short <email address hidden>

commit 6a019e60c3bd0943904589e47e32c732e48a8086
Author: Chris Friesen <email address hidden>
Date: Thu Mar 4 18:59:53 2021 -0500

    add dcmanager-audit-worker to sample restart script

    We've added a new distributed-cloud process, so update the sample script.

    Story: 2007267
    Task: 42000
    Signed-off-by: Chris Friesen <email address hidden>
    Change-Id: I16522744c9526e134577bda80cf91a8308eee889

commit 9a08e51d41a7b1b5d4c25c2a7775c70b57d278d9
Author: Charles Short <email address hidden>
Date: Sun Jan 24 08:36:23 2021 -0500

    Cap bandit to v1.6.2

    Cap bandit to v1.6.2 so we do not pull in a python3 only version.
    Without this fix the unit tests will fail to setup and run properly.

    Closes-Bug: 1916494

    Signed-off-by: Charles Short <email address hidden>
    Change-Id: I7afbc8d224f28146af42f43593586cd680a52aaf

commit 764a0576011c4a8cb43b2bd3ee1fd890bad6058a
Author: Don Penney <email address hidden>
Date: Mon Dec 21 15:22:29 2020 -0500

    Fix exclusion paths in cgcs-patch build_srpm.data

    The EXCLUDE_LIST_FROM_TAR list in cgcs-patch build_srpm.data includes
    entries to exclude .tox and other dirs when building the package, but
    the path included an extra directory level. This update corrects the
    paths.

    Change-Id: I8b3641e4e86f52ef7b9fb56f9eb3df289935e188
    Closes-Bug: 1908940
    Signed-off-by: Don Penney <email address hidden>

commit adaaba0c21e78a2a24c459e34ea7c9963024e3f6
Author: Don Penney <email address hidden>
Date: Thu Dec 17 13:17:58 2020 -0500

    Add auto-version for remaining stx/update packages

    Update remaining StarlingX packages with hardcoded TIS_PATCH_VER to
    use PKG_GITREVCOUNT where possible, with offsets as needed to ensure
    the version is incremented above the hardcoded version.

    Change-Id: I877a6c0802a707863a3b6c7d430146431e10a3ad
    Story: 2008455
    Task: 41459
    Signed-off-by: Don Penney <email address hidden>

commit 62a66370cac70a62f827fedfc8b76284fde006d3
Author: Don Penney <email address hidden>
Date: Thu Nov 19 10:41:27 2020 -0500

    Add protection a...