Comment 0 for bug 1890521

Brief Description
-----------------
subcloud2 FPGA update failed, but "dcmanager fw-update-strategy show" shows complete

Severity
--------
Major

Steps to Reproduce
------------------
precondition: subcloud2 FPGA has flashed root-key image
"dcmanager fw-update-strategy apply" to update subcloud2 FPGA with an unsigned image

Expected Behavior
------------------
subcloud2 FPGA updates failed, and "dcmanager fw-update-strategy show" shows failed

Actual Behavior
----------------
subcloud2 FPGA updates failed, but "dcmanager fw-update-strategy show" shows complete

Reproducibility
---------------
permanent

System Configuration
--------------------
Lab-name: DC-3

Branch/Pull Time/Commit
-----------------------
2020-07-31_20-00-00

Last Pass
---------
N/A

Timestamp/Logs
--------------
### on SystemController:
[sysadmin@controller-0 ~(keystone_admin)]$ system --os-region-name SystemController device-image-show 1e43227a-13db-41f4-a9c9-0e95c9219001
+----------------+--------------------------------------------------+
| Property | Value |
+----------------+--------------------------------------------------+
| uuid | 1e43227a-13db-41f4-a9c9-0e95c9219001 |
| bitstream_type | functional |
| pci_vendor | 8086 |
| pci_device | 0b30 |
| bitstream_id | 1 |
| key_signature | None |
| revoke_key_id | None |
| name | None |
| description | None |
| image_version | None |
| applied | True |
| applied_labels | [{u'subcloud2': u'002'}, {u'subcloud4': u'004'}] |
+----------------+--------------------------------------------------+

[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager fw-update-strategy show
+------------------------+----------------------------+
| Field | Value |
+------------------------+----------------------------+
| strategy type | firmware |
| subcloud apply type | None |
| max parallel subclouds | None |
| stop on failure | False |
| state | complete |
| created_at | 2020-08-06 02:54:57.357858 |
| updated_at | 2020-08-06 03:29:32.879757 |
+------------------------+----------------------------+

[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager strategy-step list
+-----------+-------+----------+---------+----------------------------+----------------------------+
| cloud | stage | state | details | started_at | finished_at |
+-----------+-------+----------+---------+----------------------------+----------------------------+
| subcloud2 | 3 | complete | | 2020-08-06 03:01:01.264087 | 2020-08-06 03:29:24.086676 |
+-----------+-------+----------+---------+----------------------------+----------------------------+

### on subcloud2:
[sysadmin@controller-0 ~(keystone_admin)]$ system device-image-show 1e43227a-13db-41f4-a9c9-0e95c9219001
+----------------+--------------------------------------+
| Property | Value |
+----------------+--------------------------------------+
| uuid | 1e43227a-13db-41f4-a9c9-0e95c9219001 |
| bitstream_type | functional |
| pci_vendor | 8086 |
| pci_device | 0b30 |
| bitstream_id | 1 |
| key_signature | None |
| revoke_key_id | None |
| name | None |
| description | None |
| image_version | None |
| applied | True |
| applied_labels | [{u'subcloud2': u'002'}] |
+----------------+--------------------------------------+

[sysadmin@controller-0 ~(keystone_admin)]$ system device-image-state-list
+--------------+----------+--------------------------------------+--------+-----------------+----------------------------------+
| hostname | PCI | Device image uuid | status | Update start | updated_at |
| | device | | | time | |
| | address | | | | |
+--------------+----------+--------------------------------------+--------+-----------------+----------------------------------+
| controller-0 | 0000:b2: | 1e43227a-13db-41f4-a9c9-0e95c9219001 | failed | 2020-08-06T03: | 2020-08-06T03:16:52.330096+00:00 |
| | 00.0 | | | 01:32.432129+00 | |
| | | | | :00 | |
| | | | | | |
+--------------+----------+--------------------------------------+--------+-----------------+----------------------------------+

[sysadmin@controller-0 ~(keystone_admin)]$ cat /var/log/kern.log | grep intel-max10
2020-08-06T03:16:51.944 controller-0 kernel: err [ 3723.365952] intel-max10 spi2.0: RSU error status: 0x02020104
2020-08-06T03:16:51.944 controller-0 kernel: err [ 3723.371703] intel-max10 spi2.0: RSU auth result: 0x00000011

### subcloud2 after automatically lock/unlock:
[sysadmin@controller-0 ~(keystone_admin)]$ system device-image-show 1e43227a-13db-41f4-a9c9-0e95c9219001
+----------------+--------------------------------------+
| Property | Value |
+----------------+--------------------------------------+
| uuid | 1e43227a-13db-41f4-a9c9-0e95c9219001 |
| bitstream_type | functional |
| pci_vendor | 8086 |
| pci_device | 0b30 |
| bitstream_id | 1 |
| key_signature | None |
| revoke_key_id | None |
| name | None |
| description | None |
| image_version | None |
| applied | False |
| applied_labels | None |
+----------------+--------------------------------------+
[sysadmin@controller-0 ~(keystone_admin)]$ system device-image-state-list

[sysadmin@controller-0 ~(keystone_admin)]$

Test Activity
-------------
Functional Testing