Comment 4 for bug 1885316

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/738268
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=d6f0688a94b667c24f8a59a4229dfa41b7991046
Submitter: Zuul
Branch: master

commit d6f0688a94b667c24f8a59a4229dfa41b7991046
Author: Jim Gauld <email address hidden>
Date: Fri Jun 26 15:24:21 2020 -0400

    kubelet does not start due to garbled cpulist

    This adds consistent quote wrapping around sysinv puppet hieradata
    values containing complex cpulist or list of ranges.

    Two new variables were introduced by commit
    92828038b4cfa720c6dfc74fbdcb2e463ac5996d Enable --reserved-cpus option
    in k8s v1.18.1.

    platform::kubernetes::params::k8s_all_reserved_cpuset, and
    platform::kubernetes::params::k8s_platform_cpuset.

    Without the quotes, any value containing a comma gets interpreted
    as octal without comma, this results in a strange invalid integer.
    This leads to kubelet fail to start. and node will not come up.

    This issue was more likely when multiple platform cores are reserved,
    and hyperthreading is enabled, since that causes non-consecutive
    integers specified in the reserved list.

    Change-Id: I029d89cd8a6f1ca12078d9b86ae05e6660fa2af6
    Closes-Bug: 1885316
    Signed-off-by: Jim Gauld <email address hidden>