Comment 2 for bug 1883519

Reviewed: https://review.opendev.org/735609
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=e379fdfe189f067445daeac69e8997192c8f0aed
Submitter: Zuul
Branch: master

commit e379fdfe189f067445daeac69e8997192c8f0aed
Author: Eric MacDonald <email address hidden>
Date: Mon Jun 15 11:09:47 2020 -0400

    Prevent pmond process recovery when system is not running

    The maintenance process monitor (pmon) should only
    recover failed processes when the system state is
    'running' or 'degraded'.

    The current implementation allowed process recovery
    for other non-inservice states, including an unknown
    state if systemd returns no data on the state query.

    This update tighten's up the system state check by
    adding retries to the state query utility and
    restricting accepted states to 'running' and 'degraded'.

    This change then prevents pmon from inadvertently killing
    and recovering the mtcClient which indirectly kills off
    the mtcClient's fail-safe sysreq reboot child thread
    if pmon state query returns anything other than running
    or degraded during a shut down.

    Change-Id: I605ae8be06f8f8351a51afce98a4f8bae54a40fd
    Closes-Bug: 1883519
    Signed-off-by: Eric MacDonald <email address hidden>