Fix wipedisk rootfs partition and bootloader removal
This commit changes:
o DD wipe is no longer executed on / or we loose access
to system commands before wipe is complete. Wiping
root beginning and end is not mandatory as on reinstall
it is reformatted.
o Partitions on rootfs, other than platform-backup are
removed.
o Bootloader is removed so that boot from secondary devices
can be done. This is useful at host reinstall. W/o this
change boot hangs and manual intervention is needed.
commit a56b99c84693149a035ffe6594099f60db71584e
Author: Ovidiu Poncea <email address hidden>
Date: Sat May 2 11:47:44 2020 -0400
Fix partition removal after wipe
After the wipe step, partitions are not removed when installing the load.
This commit fixes this.
Also, on some systems with NVMe, udev doesn't correctly remove the device
nodes to the deleted partitions from /dev/nvme* causing them to be seen as
non block devices, this leads to failures on format or assigning LVM PVs.
Add a backup partition that has
the following characteristics:
- It will never be deleted
(not at install, reinstall, upgrade nor B&R)
- The partition will have 10G
- It will be resizable at upgrades
Drop copy of .cfg files from controller kickstarts
In a boot from an ISO modified by update-iso.sh with a ks-addon, the
ks-addon.cfg was being unnecessarily copied in a kickstart postinstall
scriptlet. This behaviour, copying the .cfg files, was originally
required for copying the net-boot kickstarts for installation of other
nodes, however the kickstarts are now packaged and installed, and no
other .cfg files are required from the installation.
As such, this update drops the copying of these files.
Change-Id: Id088ff00711b0703299f822ab1f25901e94a6d4d
Closes-Bug: 1875464
Signed-off-by: Don Penney <email address hidden>
When booting via PXE one can set the ksdevice=bootif and add
'IPAPPEND 2' to the PXE boot config, this will set the MAC
address in the BOOTIF kernel cmdline which can then be used to
determine the NIC name to be used for the installation.
Tested with both valid and invalid input to BOOTIF=
1.Remove 'const' in DELIMITER to fix "Werror=ignored-qualifiers"
2.Replace sprintf with snprintf, and add return value check for
snprintf to fix "Werror=format-overflow"
3.Replace strncpy with snprintf to fix "Werror=stringop-truncation"
If the boot_device and/or rootfs_device are not set on the kernel
cmdline detect them early in the kickstart script. This can help
solve the issue about which disk type is to be used.
Remove the older code for disk detection
Tested with both sda and nvme disk types
Add mtcAgent socket initialization failure retry handling.
The main maintenance process (mtcAgent) exits on a process start-up
socket initialization failure. SM restarts the failed process within
seconds and will swact if the second restart also fails. From startup
to swact can be as quick as 4 seconds. This is too short to handle a
collision with a manifest.
This update adds a number of socket initialization retries to extend
the time the process has to resolve socket initialization failures by
giving the collided manifest time to complete between retries.
The number of retries and inter retry wait time is calibrated to ensure
that a persistently failing mtcAgent process exits in under 40 seconds.
This is to ensure that SM is able to detect and swact away from a
persistently failing maintenance process while also giving the process
a few tries to resolve on its own.
Test Plan:
PASS: Verify socket init failure thresholded retry handling
with no, persistent and recovered failure conditions.
PASS: Verify swact if socket init failure is persistent
PASS: Verify no swact if socket failure recovers after first exit
PASS: Verify no swact if socket failure recovers over init retry
PASS: Verify an hour long soak of continuous socket open/close retry
Change-Id: I3cb085145308f0e920324e22111f40bdeb12b444
Closes-Bug: 1869192
Signed-off-by: Eric MacDonald <email address hidden>
Reviewed: https:/ /review. opendev. org/729821 /git.openstack. org/cgit/ starlingx/ metal/commit/ ?id=51bd3f94554 4cb97da2ef2a0b1 2bdf2c5468514c
Committed: https:/
Submitter: Zuul
Branch: f/centos8
commit efbaf2cd0db97fc 1b43ffbf2a8346e b12638a08f
Author: Sharath Kumar K <email address hidden>
Date: Mon May 4 10:24:30 2020 +0200
De-branding in starlingx/metal: TIS -> StarlingX
1. Rename TIS to StarlingX for .spec file
Test:
After the de-brand change, bootimage.iso has been built in the flock
Layer and installed on the dev machine to validate the changes.
Please note, doing de-brand changes in batches, this is batch11 changes.
Story: 2006387
Task: 36207
Change-Id: I52673924a8186a fb7482d7ba7b601 f4733268afb
Signed-off-by: Sharath Kumar K <email address hidden>
commit 24499f8f25a72ab bb109a3a6494ad3 8744a1d147
Author: Ovidiu Poncea <email address hidden>
Date: Fri May 8 19:21:20 2020 +0300
Fix wipedisk rootfs partition and bootloader removal
This commit changes:
o DD wipe is no longer executed on / or we loose access
to system commands before wipe is complete. Wiping
root beginning and end is not mandatory as on reinstall
it is reformatted.
o Partitions on rootfs, other than platform-backup are
removed.
o Bootloader is removed so that boot from secondary devices
can be done. This is useful at host reinstall. W/o this
change boot hangs and manual intervention is needed.
Change-Id: I1ab9f70d00a385 68fc00063cdaa54 ec3be48dc33
Closes-Bug: 1877579
Signed-off-by: Ovidiu Poncea <email address hidden>
commit a56b99c84693149 a035ffe6594099f 60db71584e
Author: Ovidiu Poncea <email address hidden>
Date: Sat May 2 11:47:44 2020 -0400
Fix partition removal after wipe
After the wipe step, partitions are not removed when installing the load.
This commit fixes this.
Also, on some systems with NVMe, udev doesn't correctly remove the device
nodes to the deleted partitions from /dev/nvme* causing them to be seen as
non block devices, this leads to failures on format or assigning LVM PVs.
Change-Id: I3ab9f70d00a385 68fc00063cdaa54 ec3be48dc58
Closes-Bug: 1876374
Signed-off-by: Ovidiu Poncea <email address hidden>
commit ece0dd0ce5e36c4 61c93a5cc3b803f b3b5c5e59e
Author: Mihnea Saracin <email address hidden>
Date: Wed Apr 15 20:25:22 2020 +0300
Persistent backup partition
Add a backup partition that has
the following characteristics:
- It will never be deleted
(not at install, reinstall, upgrade nor B&R)
- The partition will have 10G
- It will be resizable at upgrades
Story: 2007403 68fc00063cdaa54 ec3be48dc47
Task: 39548
Change-Id: I2ec9f70d00a385
Signed-off-by: Mihnea Saracin <email address hidden>
commit 84c720f4562bde3 d06b245bca0b7ad 41655d35f5
Author: Don Penney <email address hidden>
Date: Mon Apr 27 22:50:10 2020 -0400
Drop copy of .cfg files from controller kickstarts
In a boot from an ISO modified by update-iso.sh with a ks-addon, the
ks-addon.cfg was being unnecessarily copied in a kickstart postinstall
scriptlet. This behaviour, copying the .cfg files, was originally
required for copying the net-boot kickstarts for installation of other
nodes, however the kickstarts are now packaged and installed, and no
other .cfg files are required from the installation.
As such, this update drops the copying of these files.
Change-Id: Id088ff00711b07 03299f822ab1f25 901e94a6d4d
Closes-Bug: 1875464
Signed-off-by: Don Penney <email address hidden>
commit 718a68ff90e8cdd d08fb1bc9005caf 5e8ef939c2
Author: Sabeel Ansari <email address hidden>
Date: Fri Apr 17 10:05:26 2020 -0400
Filter cert-manager & nginx RPMs
Cert-manager & nginx-ingress- controller packages are only needed
on controllers. Filtering them out of worker & storage nodes.
Story: 2007360
Task: 39462
Change-Id: I53b61ae0831d53 d8bfc5f41ac3724 f97a51e5d83
Signed-off-by: Sabeel Ansari <email address hidden>
commit 0b9f186330bbd7d b852645a63be260 f30e4247b7
Author: Teresa Ho <email address hidden>
Date: Thu Apr 16 00:32:18 2020 -0400
Filter OIDC rpms from worker and storage node
OIDC and DEX packages are only needed on the controllers.
Story: 2006711
Task: 39434
Change-Id: I331f2505979a9c 35430d409167af1 b1338b9a52c
Signed-off-by: Teresa Ho <email address hidden>
commit 8d1695fa6a1e318 300cffc87b0bce0 a84f41cfc9
Author: Saul Wold <email address hidden>
Date: Mon Mar 30 12:07:19 2020 -0700
Convert BOOTIF MAC to NIC name
When booting via PXE one can set the ksdevice=bootif and add
'IPAPPEND 2' to the PXE boot config, this will set the MAC
address in the BOOTIF kernel cmdline which can then be used to
determine the NIC name to be used for the installation.
Tested with both valid and invalid input to BOOTIF=
Story: 2007486 b8fb79a461ce921 0dddf2c764f
Task: 39205
Change-Id: Iec1e8215571a6b
Signed-off-by: Saul Wold <email address hidden>
commit 7423edce9bae1e5 3d0cce1d6715de1 83d1ef8e39
Author: Dongqi Chen <email address hidden>
Date: Thu Apr 2 17:25:45 2020 +0800
Fix mtce-common build error with gcc-8.2.1
gcc-8.2.1 reports "Werror= format- truncation" error due to there is
possibility the string be truncated, add return value check could
avoid the error.
Signed-off-by: Shuicheng Lin <email address hidden>
Signed-off-by: Dongqi Chen <email address hidden>
Change-Id: I8fa08077e47ee3 777a50f018af77b 3e8fc6191f9
Story: 2007506
Task: 39278
commit 456c255ea11b741 ea91eca7f0f277f 167488002f
Author: Dongqi Chen <email address hidden>
Date: Fri Apr 3 14:21:52 2020 +0800
Fix mtce build error with gcc-8.2.1
1.Remove 'const' in DELIMITER to fix "Werror= ignored- qualifiers" format- overflow" stringop- truncation"
2.Replace sprintf with snprintf, and add return value check for
snprintf to fix "Werror=
3.Replace strncpy with snprintf to fix "Werror=
Change-Id: Iecca021fc02df3 5a472a3f8aa04c9 501998e2dba
Story: 2007506
Task: 39279
Signed-off-by: Shuicheng Lin <email address hidden>
Signed-off-by: Dongqi Chen <email address hidden>
commit b725a0974b243e5 a66c976638e0350 244c89f21c
Author: Sharath Kumar K <email address hidden>
Date: Thu Apr 2 10:18:32 2020 +0200
De-branding in starlingx/metal: Titanium Cloud -> StarlingX
1. Rename Titanium Cloud to StarlingX for .spec files
2. Rename Titanium Cloud to StarlingX for .service file
Test:
After the de-brand change, bootimage.iso has built in the flock layer
and installed on the dev machine to validate the changes.
Please note, doing de-brand changes in batches, this is batch1 changes.
Story: 2006387
Task: 36207
Change-Id: Ifa4dc5c7aa3189 815e00b796fc833 852e88c8fe3
Signed-off-by: Sharath Kumar K <email address hidden>
commit f11e52b000d4250 4b49ea72fecbd4a 1852129dd1
Author: Saul Wold <email address hidden>
Date: Mon Mar 30 11:52:59 2020 -0700
Select disk via kickstart
If the boot_device and/or rootfs_device are not set on the kernel
cmdline detect them early in the kickstart script. This can help
solve the issue about which disk type is to be used.
Remove the older code for disk detection
Tested with both sda and nvme disk types
Story: 2007486 280820ceeefafaf 127cb048df6
Task: 39204
Change-Id: I4fa3b44a4e656e
Signed-off-by: Saul Wold <email address hidden>
commit 082688230827e59 ef9905aa03b9fea 7f034dfb13
Author: Eric MacDonald <email address hidden>
Date: Wed Apr 1 11:38:30 2020 -0400
Add mtcAgent socket initialization failure retry handling.
The main maintenance process (mtcAgent) exits on a process start-up
socket initialization failure. SM restarts the failed process within
seconds and will swact if the second restart also fails. From startup
to swact can be as quick as 4 seconds. This is too short to handle a
collision with a manifest.
This update adds a number of socket initialization retries to extend
the time the process has to resolve socket initialization failures by
giving the collided manifest time to complete between retries.
The number of retries and inter retry wait time is calibrated to ensure
that a persistently failing mtcAgent process exits in under 40 seconds.
This is to ensure that SM is able to detect and swact away from a
persistently failing maintenance process while also giving the process
a few tries to resolve on its own.
Test Plan:
PASS: Verify socket init failure thresholded retry handling
with no, persistent and recovered failure conditions.
PASS: Verify swact if socket init failure is persistent
PASS: Verify no swact if socket failure recovers after first exit
PASS: Verify no swact if socket failure recovers over init retry
PASS: Verify an hour long soak of continuous socket open/close retry
Change-Id: I3cb085145308f0 e920324e22111f4 0bdeb12b444
Closes-Bug: 1869192
Signed-off-by: Eric MacDonald <email address hidden>