Comment 0 for bug 1844147

Brief Description
-----------------
In a Distributed Cloud system, sysinv firewallrules audit failed.

Severity
--------
Major: System/Feature is usable but degraded

Steps to Reproduce
------------------
- Deploy a DC system with at least one subcloud.
- Manage the subcloud by:
  dcmanager subcloud manage <subcloud>
- Check /var/log/dcorch/dcorch.log in system controller
  There will be ERRORs like:
ERROR dcorch.drivers.openstack.sysinv_v1 [-] get_firewallrules region=subcloud1 exception='Client' object has no attribute 'firewallrules'

Expected Behavior
------------------
There shouldn't be ERRORs for firewallrules audit, and the audit should be successful.

Actual Behavior
----------------
Firewallrules audit failed.

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Distributed cloud with at least one subcloud.

Branch/Pull Time/Commit
-----------------------
STX master, git/distributedcloud, pulled at around Aug 26, 2019.

But the issue exists as latest as:
commit 2c538b9e521a5dd9a7e7a8b216a15dd47edf0ca4
Author: Scott Little <email address hidden>
Date: Thu Sep 5 14:52:07 2019 -0400

Last Pass
---------
Unknown.

Timestamp/Logs
--------------
2019-08-26 21:20:26.351 104053 ERROR dcorch.drivers.openstack.sysinv_v1 [-] get_firewallrules region=subcloud1 exception='Client' object has no attribute 'firewallrules'
2019-08-26 21:20:26.352 104053 ERROR dcorch.engine.sync_services.sysinv [-] The sync operation failed, will retry: SyncRequestFailedRetry: The sync operation failed, will retry
2019-08-26 21:20:26.352 104053 ERROR dcorch.engine.sync_services.sysinv Traceback (most recent call last):
2019-08-26 21:20:26.352 104053 ERROR dcorch.engine.sync_services.sysinv File "/usr/lib/python2.7/site-packages/dcorch/engine/sync_services/sysinv.py", line 1041, in get_firewallrules_resource
2019-08-26 21:20:26.352 104053 ERROR dcorch.engine.sync_services.sysinv ifirewallrules = os_client.sysinv_client.get_firewallrules()
2019-08-26 21:20:26.352 104053 ERROR dcorch.engine.sync_services.sysinv File "/usr/lib/python2.7/site-packages/dcorch/drivers/openstack/sysinv_v1.py", line 484, in get_firewallrules
2019-08-26 21:20:26.352 104053 ERROR dcorch.engine.sync_services.sysinv raise exceptions.SyncRequestFailedRetry()
2019-08-26 21:20:26.352 104053 ERROR dcorch.engine.sync_services.sysinv SyncRequestFailedRetry: The sync operation failed, will retry
2019-08-26 21:20:26.352 104053 ERROR dcorch.engine.sync_services.sysinv
2019-08-26 21:20:26.356 104053 INFO dcorch.drivers.openstack.sdk_platform [-] get new keystone client for subcloud RegionOne
2019-08-26 21:20:27.844 104053 ERROR dcorch.drivers.openstack.sysinv_v1 [-] get_firewallrules region=RegionOne exception='Client' object has no attribute 'firewallrules'
2019-08-26 21:20:27.844 104053 ERROR dcorch.engine.sync_services.sysinv [-] The sync operation failed, will retry: SyncRequestFailedRetry: The sync operation failed, will retry
2019-08-26 21:20:27.844 104053 ERROR dcorch.engine.sync_services.sysinv Traceback (most recent call last):
2019-08-26 21:20:27.844 104053 ERROR dcorch.engine.sync_services.sysinv File "/usr/lib/python2.7/site-packages/dcorch/engine/sync_services/sysinv.py", line 1041, in get_firewallrules_resource
2019-08-26 21:20:27.844 104053 ERROR dcorch.engine.sync_services.sysinv ifirewallrules = os_client.sysinv_client.get_firewallrules()
2019-08-26 21:20:27.844 104053 ERROR dcorch.engine.sync_services.sysinv File "/usr/lib/python2.7/site-packages/dcorch/drivers/openstack/sysinv_v1.py", line 484, in get_firewallrules
2019-08-26 21:20:27.844 104053 ERROR dcorch.engine.sync_services.sysinv raise exceptions.SyncRequestFailedRetry()
2019-08-26 21:20:27.844 104053 ERROR dcorch.engine.sync_services.sysinv SyncRequestFailedRetry: The sync operation failed, will retry
2019-08-26 21:20:27.844 104053 ERROR dcorch.engine.sync_services.sysinv
2019-08-26 21:20:27.845 104053 INFO dcorch.engine.sync_thread [-] subcloud1/platform: Audit firewallrules: [None] vs [None]
2019-08-26 21:20:27.845 104053 ERROR dcorch.engine.sync_services.sysinv [-] no get_resource_id for firewall

Test Activity
-------------
Found while do feature development.