Comment 0 for bug 1843915

Brief Description
-----------------
Cannot deploy an application by helm chart upload which is pointing to an image on local registry
Severity
--------
Provide the severity of the defect.
Major: System/Feature is usable but degraded

Steps to Reproduce
------------------
1. Have a SXT deploymen up an running, with stx-openstack application correctly applied
2. Copy `hello-kitty.tgz` file (attached) to the active controller
3. Modify the `values.yaml` file adding the <REGISTRY IP> on:
    - charts/hello-kitty/values.yaml
    - charts/hello-kitty.tgz/hello-kitty/values.yaml

   as follows:

    images:
      pullPolicy: IfNotPresent
      tags:
        hellokitty: <REGISTRY_IP>/gwaines/hellokitty:v1.0

3. on active controller do
   $ . /etc/platform/openrc
   $ system application-upload -n hello-kitty -v 1.0 /home/sysadmin/hello-kitty.tgz
     # wait until is uploaded correctly
   $ system application-apply hello-kitty

Expected Behavior
------------------
Application should be applied correctly.

Actual Behavior
----------------
Application cannot be applied due cannot download images

NOTE: Note: If we do a `sudo docker pull : <REGISTRY_IP>/gwaines/hellokitty:v1.0` image is pulled correctly, also this works correctly when the image is downloaded from the public registry.

======== Logs ==============================================================================

2019-09-12 13:26:40.036 328907 INFO sysinv.conductor.kube_app [-] Application hello-kitty (1.0) upload completed.
2019-09-12 13:26:41.306 330854 INFO sysinv.api.controllers.v1.host [-] Provisioned storage node(s) []
2019-09-12 13:26:41.381 330854 INFO sysinv.api.controllers.v1.host [-] Provisioned storage node(s) []
2019-09-12 13:26:43.448 330855 INFO sysinv.openstack.common.rpc.common [-] Connected to AMQP server on 10.10.62.2:5672
2019-09-12 13:26:43.457 328907 INFO sysinv.conductor.kube_app [-] Register the initial abort status of app hello-kitty
2019-09-12 13:26:43.586 328907 INFO sysinv.conductor.kube_app [-] Application hello-kitty (1.0) apply started.
2019-09-12 13:26:43.618 328907 INFO sysinv.conductor.kube_app [-] Generating application overrides...
2019-09-12 13:26:43.682 328907 INFO sysinv.helm.manifest_base [req-202eb504-da89-4ce2-848c-18a0ea84f154 admin admin] Delete manifest file /opt/platform/armada/19.08/hello-kitty/1.0/hello-kitty-manifest-del.yaml generated
2019-09-12 13:26:43.683 328907 INFO sysinv.conductor.kube_app [-] Application overrides generated.
2019-09-12 13:26:43.784 328907 INFO sysinv.conductor.kube_app [-] Image 192.168.90.60/gwaines/hellokitty:v1.0 download started from public/private registry
2019-09-12 13:26:43.785 328907 ERROR sysinv.conductor.kube_app [-] Image 192.168.90.60/gwaines/hellokitty:v1.0 download failed from public/private registry: 'module' object has no attribute 'SERVICE_PARAM_NAME_DOCKER_DOCKER_REGISTRY'
2019-09-12 13:26:43.786 328907 ERROR sysinv.conductor.kube_app [-] Deployment of application hello-kitty (1.0) failed: failed to download one or more image(s).
2019-09-12 13:26:43.786 328907 TRACE sysinv.conductor.kube_app Traceback (most recent call last):
2019-09-12 13:26:43.786 328907 TRACE sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/conductor/kube_app.py", line 1812, in perform_app_apply
2019-09-12 13:26:43.786 328907 TRACE sysinv.conductor.kube_app self._download_images(app)
2019-09-12 13:26:43.786 328907 TRACE sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/conductor/kube_app.py", line 763, in _download_images
2019-09-12 13:26:43.786 328907 TRACE sysinv.conductor.kube_app reason=reason)
2019-09-12 13:26:43.786 328907 TRACE sysinv.conductor.kube_app KubeAppApplyFailure: Deployment of application hello-kitty (1.0) failed: failed to download one or more image(s).
2019-09-12 13:26:43.786 328907 TRACE sysinv.conductor.kube_app
2019-09-12 13:26:44.020 328907 ERROR sysinv.conductor.kube_app [-] Application apply aborted!.
2019-09-12 13:26:44.020 328907 INFO sysinv.conductor.kube_app [-] Deregister the abort status of app hello-kitty
2019-09-12 13:26:44.021 328907 ERROR sysinv.openstack.common.rpc.amqp [req-202eb504-da89-4ce2-848c-18a0ea84f154 admin admin] Exception during message handling
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp Traceback (most recent call last):
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/openstack/common/rpc/amqp.py", line 438, in _process_data
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp **args)
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/openstack/common/rpc/dispatcher.py", line 172, in dispatch
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp result = getattr(proxyobj, method)(ctxt, **kwargs)
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/conductor/manager.py", line 10172, in perform_app_apply
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp app_applied = self._app.perform_app_apply(rpc_app, mode)
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/conductor/kube_app.py", line 1812, in perform_app_apply
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp self._download_images(app)
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/conductor/kube_app.py", line 763, in _download_images
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp reason=reason)
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp KubeAppApplyFailure: Deployment of application hello-kitty (1.0) failed: failed to download one or more image(s).
2019-09-12 13:26:44.021 328907 TRACE sysinv.openstack.common.rpc.amqp

=========================================================================================

Reproducibility
---------------
<Reproducible/Intermittent/Seen once>
100%

System Configuration
--------------------
Multi-node system - Local Storage

Branch/Pull Time/Commit
-----------------------
Master

OS="centos"
SW_VERSION="19.09"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="20190913T013000Z"

JOB="STX_build_master_master"
<email address hidden>"
BUILD_NUMBER="247"
BUILD_HOST="starlingx_mirror"
BUILD_DATE="2019-09-13 01:30:00 +0000"

http://mirror.starlingx.cengn.ca/mirror/starlingx/master/centos/20190913T013000Z/

Last Pass
---------
First Time tested

Timestamp/Logs
--------------
File hello-kitty.tgz attached

Test Activity
-------------
Pytest automated suite enablement