horizon show incorrect failure error message for patch orchestration apply and abort

[Anujeyan Manokeran]

Brief Description
-----------------
      During the patch orchestration testing using horizon gui it was observed orchestration apply or abort when it goes to apply or abort success it shows a error message as strategy failure or abort failure but actually it was success . Check the attached image for horizon error .. Since horizon doesn’t have auto refresh when I refresh the page to see the progress this shows up.
Below cli says success but attached horizon display have a strategy apply failure.

[sysadmin@controller-0 ~(keystone_admin)]$ sw-manager patch-strategy show
Strategy Patch Strategy:
  strategy-uuid: da42c14d-5af1-44ca-9e26-f18a94344a32
  controller-apply-type: serial
  storage-apply-type: serial
  worker-apply-type: serial
  default-instance-action: stop-start
  alarm-restrictions: relaxed
  current-phase: apply
  current-phase-completion: 100%
  state: applied
  apply-result: success
  apply-reason:

Severity
--------
Major
Steps to Reproduce
------------------
1. Upload patch
2. Create patch strategy using horizon software management patch orchestration
3. apply strategy
4. Wait for strategy to complete . Refresh the horizon to verify patch strategy apply progress.
5. As description says after patch apply success horizon also displays error apply failure as attached image.

System Configuration
--------------------
Regular system

Expected Behavior
------------------
No error message on horizon when it is success.
Actual Behavior
----------------
Failure as per description error message with success.
Reproducibility
---------------
100% reproducible
System Configuration
--------------------
Regular system
Load
----
2019-09-04_00-10-00

Last Pass
---------
Timestamp/Logs
--------------
2019-09-04T17:36:31
Test Activity
-------------
Regression test

[Ghada Khalil (gkhalil)]

Marking as stx.3.0 / medium priority - error is reproducible and would be confusing to users.

[Bin Qian (bqian20)]

Reproduced the issue. This is a user operation issue. By refresh the browser, after browser prompts the user to confirm if the resubmission is intended, the last http request is sent to the server. The last request is to apply strategy, the same action is requested the 2nd time and with the strategy has been already completed, the strategy is no longer available to execute. That's why the error pop up. See the screenshot prompting "any action you took to be repeated".
This is not a software issue.

[Bin Qian (bqian20)]

browser prompts to confirm form resubmission

[Bin Qian (bqian20)]

To avoid seeing this "error", user can click on the "software management" link on the left side menu bar to refresh the software management page, after that, refresh the page as much as he/she likes.

[Bin Qian (bqian20)]

should use "post/redirect" pattern to avoid refresh form submit.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/688922

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/688922
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=2e546d8fa1950d5b3a6489cd1ffc89638c49458b
Submitter: Zuul
Branch: master

commit 2e546d8fa1950d5b3a6489cd1ffc89638c49458b
Author: Bin Qian <email address hidden>
Date: Wed Oct 16 08:50:49 2019 -0400

    Eliminate form resubmit at browser reload on software management

    Apply post/redirect to eliminate form resubmit at browser reload
    on software management page.

    Closes-Bug: 1842747

    Change-Id: Icd637ccef543e25ffce35de05bc3981da1902229
    Signed-off-by: Bin Qian <email address hidden>

[Anujeyan Manokeran (anujeyan)]

Verified in load 2019-10-18_20-00-00.

[Anujeyan Manokeran (anujeyan)]

LP https://bugs.launchpad.net/starlingx/+bug/1849181 was open track as horizon only issue.

[Anujeyan Manokeran (anujeyan)]

Ignore above comments it was put there by mistake.