commit abaff6b27525aaa91df53319f84004640f75e6a3
Author: Eric MacDonald <email address hidden>
Date: Fri Jan 18 16:29:56 2019 -0500
Remove alarm query before clear in NTP plugin
Issue titled 'NTP 100.14 alarm is not cleared' exposed
an issue where the NTP plugin alarm clear operation is
circumvented when its pre-curser fm_api.get_fault call
returns None if the fm process is not running.
From the callers point of view the None return suggests
that the alarm to be cleared does not exist so the code
skips the call to clear.
This update works around this by simply issuing the
clear without the query.
Change-Id: Idcc05bb0e7e1aa1082af1e8ecdcb1a5463b19440
Closes-Bug: 1812440
Signed-off-by: Eric MacDonald <email address hidden>
Reviewed: https:/ /review. openstack. org/631888 /git.openstack. org/cgit/ openstack/ stx-integ/ commit/ ?id=abaff6b2752 5aaa91df53319f8 4004640f75e6a3
Committed: https:/
Submitter: Zuul
Branch: master
commit abaff6b27525aaa 91df53319f84004 640f75e6a3
Author: Eric MacDonald <email address hidden>
Date: Fri Jan 18 16:29:56 2019 -0500
Remove alarm query before clear in NTP plugin
Issue titled 'NTP 100.14 alarm is not cleared' exposed
an issue where the NTP plugin alarm clear operation is
circumvented when its pre-curser fm_api.get_fault call
returns None if the fm process is not running.
From the callers point of view the None return suggests
that the alarm to be cleared does not exist so the code
skips the call to clear.
This update works around this by simply issuing the
clear without the query.
Change-Id: Idcc05bb0e7e1aa 1082af1e8ecdcb1 a5463b19440
Closes-Bug: 1812440
Signed-off-by: Eric MacDonald <email address hidden>