Comment 2 for bug 1807097

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-metal (master)

Reviewed: https://review.openstack.org/623149
Committed: https://git.openstack.org/cgit/openstack/stx-metal/commit/?id=a92c543fd574e027f0de0bd17d8a67090364ef3d
Submitter: Zuul
Branch: master

commit a92c543fd574e027f0de0bd17d8a67090364ef3d
Author: Yan Chen <email address hidden>
Date: Fri Dec 7 00:47:21 2018 +0800

    No json_object_put() for the json_obj created by json_object_object_get_ex().

    It is stated in the json_object.h from version 0.11:
    https://github.com/json-c/json-c/blob/json-c-0.11/json_object.h#L271

    As on json-c 0.11, there's no assert to check for the ref_count, we wont get
      crashed. But on json-c 0.13.1 (latest release), json_object_put will check
      for the ref_count first, so mtcAgent will crash.

    Test Done:
    Run mtcAgent with json-c version 0.13.1 with this patch, no crash found.

    Closes-Bug: 1807097

    Change-Id: I7f954c97804ae01f831c94a36b9dbdbb34dbf083
    Signed-off-by: Yan Chen <email address hidden>