Comment 1 for bug 1800889

Reviewed: https://review.openstack.org/614627
Committed: https://git.openstack.org/cgit/openstack/stx-integ/commit/?id=2936d5d56892ee98b7c5613714f7e89545614123
Submitter: Zuul
Branch: master

commit 2936d5d56892ee98b7c5613714f7e89545614123
Author: Daniel Badea <email address hidden>
Date: Wed Oct 31 19:34:14 2018 +0000

    ceph-disk prepare invalid data disk value

    ceph-disk prepare data OSD parameter contains a new line causing
    puppet manifest to fail:

    1. $data = generate('/bin/bash','-c',"/bin/readlink -f ${name}")

       is expanded together with a new line in:

       exec { $ceph_prepare:
         command => "/usr/sbin/ceph-disk prepare ${cluster_option}
                        ${cluster_uuid_option} ${uuid_option}
                        --fs-type xfs --zap-disk ${data} ${journal}"

       just before ${journal} is expanded. Puppet reports:

         sh: line 1: : command not found

       when trying to run '' (default journal value).

    2. 'readlink' should be called when running ceph-disk prepare
       command, not when the puppet resource is defined. Let
       exec's shell call readlink instead of using puppet's
       generate() . See also:

         https://github.com/openstack/puppet-ceph/commit/ff2b2e689846dd3d980c7c706c591e8cfb8f33a9

    Added --verbose and --log-stdout options to log commands executed
    by 'ceph-disk prepare' and identify where it fails.

    Closes-Bug: 1800889
    Change-Id: I6b71147706edb97d5a1e6579924d45b999efe98f
    Signed-off-by: Daniel Badea <email address hidden>