Comment 10 for bug 1797909

Reviewed: https://review.openstack.org/627986
Committed: https://git.openstack.org/cgit/openstack/stx-config/commit/?id=b83ad728ce18373960c3f23cc90dcf344332cce7
Submitter: Zuul
Branch: master

commit b83ad728ce18373960c3f23cc90dcf344332cce7
Author: Eric MacDonald <email address hidden>
Date: Wed Jan 2 10:13:24 2019 -0500

    Make collectd startup dependent on networking Anchor

    Starting collectd too early in the manifest apply is seen
    to occasionally fail due to a dependency configuration on
    hostname resolution in FQDNLookup not being complete.

    This is fixed by making collectd startup have a hard
    dependency on platform::networking by-way of a manifest
    require Anchor.

    As well, to handle the DOR case when controller manifest
    is not executed, this update also ensures that collectd
    and influxdb services are enabled in its manifest base
    class so these processes are auto started by init.

    Since influxdb is a controller only service it is removed
    from non controller load types.

    This issue is fixed by the following multi-git changes.

    stx-metal:
       Filter influxdb out of storage and compute only loads.
       No real inter git merge dependency

    stx-integ:
       Add startup Before=pmond dependency

    stx-config: This Update.
       Move collectd config and startup to manifest apply post stage
       Move influxdb config and startup to manifest apply post stage

    Test Plan:
    PASS: Build iso
    PASS: Verify install storage system and collectd startup
    PASS: Verify influxdb and extensions excluded in non-controller loads
    PASS: Verify collectd starts properly on all nodes (CC,DOR,UNLOCK)
    PASS: Verify influxdb starts properly on controller nodes (CC,DOR,UNLOCK)
    PASS: Verify collectd pmond process monitoring and recovery
    PASS: Verify influxdb pmond process monitoring and recovery
    PASS: Verify collectd statistics storage and fetch to/from influxdb
    PASS: Verify Install AIO DX and verify collectd and influxdb startup
    PASS: Verify Storage system DOR
    PASS: Verify AIO DX DOR

    Change-Id: Idff6382d835289f5986e98e3b4ee6e9c7a960287
    Closes-Bug: 1797909
    Signed-off-by: Eric MacDonald <email address hidden>